Extract GPIO pin number constants to common enum #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samderanova
reviewed
May 28, 2024
|
Thanks for working on this! Maybe there should also be some sort of mechanism that enforces only one use of each pin at a time. I suppose we can also ignore the error in the checks regarding the unused enum field. |
taesungh
commented
May 28, 2024
There was a problem hiding this comment.
A regular enum would enforce enum fields to be discriminant whereby having multiple of the same value would be an error, but using a regular enum would require casting each pin value with as u8 when passed into Gpio::get which seems inconvenient (and more generally risks lossy conversion), but perhaps this is preferred to enforce discriminants.
samderanova
approved these changes
May 29, 2024
|
Actually, I found a suitable compromise for having the enum, will update soon. |
- Move all constants for GPIO pin numbers used by components to a single module to avoid having conflicting numbers - Use a struct instead of enum to avoid needing to cast `as u8`
- Install `num_enum` in `pod-operation` - Implements `From<Enum>` for underlying u8 repr so we can use `.into()`
taesungh
changed the title
samderanova
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #84.
Changes
GpioPinsenum will enforce discriminantnum_enum::IntoPrimitiveto convert from enum value tou8using.into()