Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Faulted state for pod failures #78

Merged
merged 5 commits into from
May 28, 2024
Merged

Add new Faulted state for pod failures #78

merged 5 commits into from
May 28, 2024

Conversation

ryescholin
Copy link
Member

@ryescholin ryescholin commented May 26, 2024

Transition to Faulted instead of Halted when pressure drops or temperature rises.
Resolves #74.

@ryescholin ryescholin requested a review from a team May 28, 2024 03:40
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Please squash during merge once it's been approved by another.

@ryescholin ryescholin requested a review from taesungh May 28, 2024 05:03
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding, one note for future planning.

@ryescholin ryescholin merged commit af5c7cb into main May 28, 2024
2 checks passed
vrushang1234 pushed a commit that referenced this pull request May 29, 2024
@taesungh taesungh deleted the faulted branch May 29, 2024 03:49
vrushang1234 added a commit that referenced this pull request Jun 1, 2024
* sensor values in control station

* chk

* chk

* chk

* Display current FSM state in control panel (#61)

* Add new Faulted state for pod failures (#78)

Add faulted to podop

* Added sensor values to gui

* Added sensor values to GUI

* Added sensor values to GUI while solving issues for frontend

* fix serde error

* uncomment

* remove checks

* Final commit

* Final commit

* Made some UI changes

* Made some changes tothe UI

* Update control-station/src/services/PodSocketClient.ts

Co-authored-by: Taesung Hwang <[email protected]>

* Changed datatypes

* Sending distance and speed

* Changed interface name

* Made serverResponse Partial

* Made serverResponse Partial

---------
Showing sensor values to the sensor boxes in GUI. Changed the size of statusIndicator to fit more sensorBoxes.

Co-authored-by: Sam Der <[email protected]>
Co-authored-by: vrushang1234 <[email protected]>
Co-authored-by: Vrushang Anand <[email protected]>
Co-authored-by: Taesung Hwang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pod] Add new Faulted state for pod failures
3 participants