-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Faulted state for pod failures #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taesungh
reviewed
May 27, 2024
samderanova
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Please squash during merge once it's been approved by another.
taesungh
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding, one note for future planning.
taesungh
reviewed
May 28, 2024
vrushang1234
added a commit
that referenced
this pull request
Jun 1, 2024
* sensor values in control station * chk * chk * chk * Display current FSM state in control panel (#61) * Add new Faulted state for pod failures (#78) Add faulted to podop * Added sensor values to gui * Added sensor values to GUI * Added sensor values to GUI while solving issues for frontend * fix serde error * uncomment * remove checks * Final commit * Final commit * Made some UI changes * Made some changes tothe UI * Update control-station/src/services/PodSocketClient.ts Co-authored-by: Taesung Hwang <[email protected]> * Changed datatypes * Sending distance and speed * Changed interface name * Made serverResponse Partial * Made serverResponse Partial --------- Showing sensor values to the sensor boxes in GUI. Changed the size of statusIndicator to fit more sensorBoxes. Co-authored-by: Sam Der <[email protected]> Co-authored-by: vrushang1234 <[email protected]> Co-authored-by: Vrushang Anand <[email protected]> Co-authored-by: Taesung Hwang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition to
Faulted
instead ofHalted
when pressure drops or temperature rises.Resolves #74.