Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display current FSM state in control panel #61

Merged
merged 6 commits into from
May 28, 2024
Merged

Display current FSM state in control panel #61

merged 6 commits into from
May 28, 2024

Conversation

samderanova
Copy link
Contributor

Resolves #50.

  • Created a new enum State that represents the current state of the pod in the GUI frontend
  • Modify PodData interface to include the current state as a field
  • Display the current state in ControlPanel

@samderanova samderanova requested a review from a team May 18, 2024 22:20
@samderanova samderanova linked an issue May 18, 2024 that may be closed by this pull request
[GUI] Display current state in control panel #50
Closed
@taesungh taesungh mentioned this pull request May 24, 2024
Closed
taesungh
taesungh requested changes May 25, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, one issue on usage and thoughts on initial value along with smaller chore.

control-station/src/services/usePodData.tsx Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
control-station/src/services/PodSocketClient.ts Outdated Show resolved Hide resolved
@samderanova samderanova marked this pull request as ready for review May 27, 2024 04:42
taesungh
taesungh approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright for now, thanks for also adding the Faulted state. Might want to eventually consider using SASS or CSS modules for more organized styles.

@taesungh taesungh mentioned this pull request May 28, 2024
Closed
@ryescholin ryescholin self-requested a review May 28, 2024 03:46
ryescholin
ryescholin approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@ryescholin ryescholin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samderanova samderanova merged commit e3a54fe into main May 28, 2024
2 checks passed
vrushang1234 pushed a commit that referenced this pull request May 29, 2024
@samderanova @vrushang1234
Display current FSM state in control panel (#61)
4bf2030
@taesungh taesungh deleted the feature/display-current-state branch May 29, 2024 03:49
vrushang1234 added a commit that referenced this pull request Jun 1, 2024
@ryescholin @samderanova
@vrushang1234 @taesungh
Display sensor values in control station GUI (#81)
dd20036 
* sensor values in control station

* chk

* chk

* chk

* Display current FSM state in control panel (#61)

* Add new Faulted state for pod failures (#78)

Add faulted to podop

* Added sensor values to gui

* Added sensor values to GUI

* Added sensor values to GUI while solving issues for frontend

* fix serde error

* uncomment

* remove checks

* Final commit

* Final commit

* Made some UI changes

* Made some changes tothe UI

* Update control-station/src/services/PodSocketClient.ts

Co-authored-by: Taesung Hwang <[email protected]>

* Changed datatypes

* Sending distance and speed

* Changed interface name

* Made serverResponse Partial

* Made serverResponse Partial

---------
Showing sensor values to the sensor boxes in GUI. Changed the size of statusIndicator to fit more sensorBoxes.

Co-authored-by: Sam Der <[email protected]>
Co-authored-by: vrushang1234 <[email protected]>
Co-authored-by: Vrushang Anand <[email protected]>
Co-authored-by: Taesung Hwang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryescholin ryescholin ryescholin approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GUI] Display current state in control panel
3 participants
@samderanova @taesungh @ryescholin