-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement feature flags for conditional compilation #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new `rpi` feature which includes `rppal` as a dependency which is otherwise optional
- Create mocks for `InputPin` and `OutputPin`
- Mock measurements from ADS1015, INA219, and mpu6050
taesungh
force-pushed
the
feature/conditional-compilation
branch
4 times, most recently
from
June 1, 2024 06:20
c82a42d
to
06f9246
Compare
- Update checks workflow and precommit hooks - Resolve clippy lint issues - Create mod for GPIO mocks
taesungh
force-pushed
the
feature/conditional-compilation
branch
from
June 1, 2024 06:27
06f9246
to
5afbf4a
Compare
samderanova
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. It'll definitely make the testing process a lot easier.
ryescholin
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!
This was referenced Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pod program cannot be run properly unless on an actual Raspberry Pi. To simplify testing of state transitions and sending data to the control station as well as testing individual components even on the Pi, we can use feature flags to conditionally enable different component features to use. Each sensor type has a feature and the
rpi
feature will enable all of them.Resolves #40.
Changes
brpi
alias to do a release build with the aarch64 architecture for the Raspberry Pirpi
feature