Code that fixes CSTP conductance decay bug #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progress toward bug fix with CSTP copyampasyni function is successfully compiling in snn_cpu_module.cpp copyampasyni function is successfully also compiling in snn_gpu_module.cpp memcpy may be working runtimeDataGPU.AMPA_syn_i is now reading and writing values runtimeDataGPU.AMPA_syn_i is now persistantly storing values throughout the sim ampa current appear to successfully compute with new approach using GPU parallelization progress toward all currents working with new method all currents successfully working with new method progress with getting all synapse processed with new nethod auto sizing of syn_i arrays seems to work better auto sizing of syn_i arrays might be fully working now added ca3cstp_taud unit test ca3cstp_taud unit test corrected possibly synapse id issue is fixed with synId now being used cleaned up extra code code further tidied up fixed synId = 0 positions added synId counter reset function added synId counter reset function updated STP calc fixed kernel_STPInit() bug attempted fix of synId for STP calcs cleaned up new code additions work in progress of cstp bug fix work in progress of cstp bug fix work in progress with cstp bug fix work in progress with cstp bug fix candidate CSTP bug fix that works successfully candidate CSTP bug fix that works successfully candidate CSTP bug fix that works successfully potentially fixed tau_d indexing updated synaptic spike adding current renamed variables syn_i to syn_g because that fits their basis equations better work-in-progress on higher performance and capacity version of the CSTP patch work-in-progress on higher performance and capacity version of the CSTP patch potential higher capacity version working now progress toward high-capacity cstp fix working higher capacity cstp fix version now potentially fully working possibly fully working high-capacity cstp patch version. however more testing including watching for race conditions should be done. changed print flags fixed nmda decay removed some atomicadd operations because they appear unneeded and take longer to compute removed some atomicadd operations because they appear unneeded and take longer to compute removed some no longer used functions and variables removed some no longer used functions and variables condensed some operations code revision that appear to cause a significant speed increase code revision that appear to cause a significant speed increase code revision that appear to cause a significant speed increase reduced the number of computations in the synapse decay code added some recoding to make synapse calc less operations and more clear fixed atomicadd operations fixed atomicadd operations reduced nmda calcs in conductanceUpdate() in synapse conductance pitched memory, post is now row index and pre is column index in 2D array, instead of the other way around. This makes more intuitive sense. fixed cudaMallocPitch memory allocation Combined commits to CSTP bug fix code into one commit
…onductance decay. The default is to use doubles. Doubles uses some more GPU RAM but is a bit more accurate.
larsnm
approved these changes
May 25, 2023
larsnm
approved these changes
May 25, 2023
larsnm
approved these changes
May 25, 2023
larsnm
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is designed to fix issue 18. This fix is for CSTP code incorrectly processing conductance decays in synaptic signals. More details are described on the issue 18 page.