-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of tools/pti #90
Open
SigmaX
wants to merge
13
commits into
dev/carlsim5
Choose a base branch
from
feat/pti-issue-81
base: dev/carlsim5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directory and configure the make file to build it along with the other tools.
…nfigure the CARLsim makefiles to build it along with the other tools.
…n be inserted by doxygen, and work on getting the PTI examples to build again.
…with the development version of ECJ (soon to be ECJ 28).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite of the old ECJ parameter-tuning interface at
tools/ecj_pti
. It replacesecj_pti
with a newtools/pti
directory, and tweaks the makefiles so that the PTI builds along withlibcarlsim
by default like the other "tools."The old Java code has been deleted entirely (its functionality will be handled out-of-the-box by ECJ 28 when it's released), and the C++ classes and examples that define the standard PTI interface have been simplified and documented.
I do not currently have access to GPU machines, so I could use someone's helping running the tests to verify this PR before it's merged!
This PR does not include updates to the tutorial or user guide. I'll address those with a future PR.