Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of tools/pti #90

Open
wants to merge 13 commits into
base: dev/carlsim5
Choose a base branch
from
Open

Rewrite of tools/pti #90

wants to merge 13 commits into from

Conversation

SigmaX
Copy link
Contributor

@SigmaX SigmaX commented Jul 13, 2020

This PR is a rewrite of the old ECJ parameter-tuning interface at tools/ecj_pti. It replaces ecj_pti with a new tools/pti directory, and tweaks the makefiles so that the PTI builds along with libcarlsim by default like the other "tools."

The old Java code has been deleted entirely (its functionality will be handled out-of-the-box by ECJ 28 when it's released), and the C++ classes and examples that define the standard PTI interface have been simplified and documented.

I do not currently have access to GPU machines, so I could use someone's helping running the tests to verify this PR before it's merged!

This PR does not include updates to the tutorial or user guide. I'll address those with a future PR.

@SigmaX SigmaX added the ECJ label Jul 13, 2020
@SigmaX SigmaX requested a review from hkashyap July 13, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant