Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links for the get involved section #1

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

kafitzgerald
Copy link
Contributor

@kafitzgerald kafitzgerald commented Jul 17, 2024

The new website looks great 🎉!

This PR just adds a few links to the "Get Involved" section to make it a little easier to navigate.

@kafitzgerald kafitzgerald marked this pull request as draft July 17, 2024 19:15
@kafitzgerald kafitzgerald marked this pull request as ready for review July 17, 2024 19:20
@kafitzgerald
Copy link
Contributor Author

I'm still getting familiar with MkDocs, but it looks like the failure might be because of the existing reference to 'archive/index.html' rather than anything in the PR itself.

I did noticed that when I click the "Legacy Site Archive" link on the "About Us" page it throws a 404 error. Maybe the same thing?

Here's the output from the log:

  mkdocs build --strict
  shell: /usr/bin/bash -el {0}
  env:
    INPUT_RUN_POST: true
    CONDA_PKGS_DIR: /home/runner/conda_pkgs_dir
INFO    -  Cleaning site directory
INFO    -  Building documentation to directory: /home/runner/work/sea-website/sea-website/site
WARNING -  A reference to 'archive/index.html' is included in the 'nav' configuration, which is not found in the documentation files.

Aborted with 1 warnings in strict mode!
Error: Process completed with exit code 1.

@negin513
Copy link
Contributor

This looks great to me. I am taking a look at the error.

@vanderwb
Copy link
Contributor

I wouldn't worry too much about that failed test - I didn't really think it was ready for CI testing of PRs yet, but will be by the launch.

The archive part of it needs to get filled in. It's in there for a reminder to me to talk to Jeff Alipit to figure that part out.

Thanks for the super fast review and contribution!

@negin513
Copy link
Contributor

Sounds good! I just tested it and made sure that the fail is indeed triggered by the missing page.

When I updated the page to link the sea website, the test now works. PR #2 does not need to be merged for now but is more of a placeholder that the build does not have any issues.

@vanderwb : we can make a dummy 404 page in place for the archive as the placeholder so that the build does not fail, but that is just an option.

@vanderwb vanderwb merged commit 58163f1 into UCAR-SEA:main Jul 18, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants