Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/us15-privacy-settings #255

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Conversation

guzmanalejandro
Copy link
Contributor

I have made the following changes to maintain basic and simple privacy settings for the user, so that they can show their recipes to other users or not just by clicking a button.

  1. The first change made, which does not fall within the acceptance criteria of this user story, is the redefinition of the tab to edit the user profile, now it has an appearance much more similar to a post recipe, maintaining coherence within the page web, apart from what you can see, I have added a button to change the visibility that the user wants to have within their profile.
Screenshot 2023-12-13 at 19 15 41
  1. In the second part, to show more information to the user about what each type of visibility means, information has been added to each one before the user himself selects which one he prefers.
Screenshot 2023-12-13 at 19 17 14 Screenshot 2023-12-13 at 19 17 02
  1. Last but not least, if you enter a user with a public profile, you can see their recipes (as has been done until now) but if, for example, you enter the profile of a user who has it set to private, then you will not even be able to see their recipes or the list of users that you follow or that follow you (similar to what happens on other social networks such as Instagram).
Screenshot 2023-12-13 at 19 23 21

xvxnoah
xvxnoah previously approved these changes Dec 13, 2023
Copy link
Contributor

@xvxnoah xvxnoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks amazing, and it complies with all the acceptance criteria defined. Good job Alejandro!

Copy link
Contributor

@xvxnoah xvxnoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job Alejandro!

@guzmanalejandro guzmanalejandro merged commit c9009ba into develop Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants