Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/us4-recipe-details #254

Merged
merged 27 commits into from
Dec 14, 2023
Merged

Feature/us4-recipe-details #254

merged 27 commits into from
Dec 14, 2023

Conversation

ivanmansilla
Copy link
Contributor

No description provided.

@ivanmansilla ivanmansilla changed the title Feature/us5-recipe-details Feature/us4-recipe-details Dec 13, 2023
@ivanmansilla
Copy link
Contributor Author

Everything that has to do with similar recipes has been implemented once we are inside the detail of a recipe. It is a new section where 6 similar recipes appear, following the same style as the rest of the page and the user feed of how the recipes appear. If we click on one of them we will be redirected to the recipe in question:
image
image

@ivanmansilla
Copy link
Contributor Author

In agreement with the PO, the design of the similar recipes section has been modified, the title has been enlarged, everything has been put in the same colour... etc.
image

Copy link
Contributor

@BlessedLongsword BlessedLongsword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would set the Image component to cover and into a set size for consistency. If an image had a ridiculously big resolution it would break the component. If PO agrees, we can change it. Eithar way, everything seems good

@ivanmansilla
Copy link
Contributor Author

Perfect @BlessedLongsword I have spoken to the PO and he agrees with what you have said. Here you have the sample that it is already fixed;
image
image

@ivanmansilla ivanmansilla merged commit 02f2cc0 into develop Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment