Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/us10 user profile + us14 follow user #204

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

guzmanalejandro
Copy link
Contributor

No description provided.

@xvxnoah xvxnoah linked an issue Dec 3, 2023 that may be closed by this pull request
@xvxnoah xvxnoah added this to the Last Sprint milestone Dec 3, 2023
@guzmanalejandro
Copy link
Contributor Author

guzmanalejandro commented Dec 4, 2023

UPDATE 4/12:

  1. Now the user feed is divided into a For You tab and a Following tab.
  • The For You tab shows recipe recommendations from people you don't follow (now it shows all the recipes from people you don't follow, in the future we can implement logic in that aspect).
Screenshot 2023-12-04 at 10 12 23
  • The Following tab shows the last two recipes published by each user you follow (the parameter can be modified if we implement more sophisticated logic in the future).
  1. If you don't follow anyone, you are shown a list of user recommendations (with logic in the backend but at the moment it is random)
Screenshot 2023-12-04 at 10 12 49
  1. Now in the recipe detail's page the user can follow or unfollow the creator of the recipe without visiting his profile. Some visual refactor has been made.
Screenshot 2023-12-04 at 17 49 40

@xvxnoah
Copy link
Contributor

xvxnoah commented Dec 4, 2023

UPDATE 4/12:

  1. Now the user feed is divided into a For You tab and a Following tab.
  • The For You tab shows recipe recommendations from people you don't follow (now it shows all the recipes from people you don't follow, in the future we can implement logic in that aspect).
Screenshot 2023-12-04 at 10 12 23
  • The Following tab shows the last two recipes published by each user you follow (the parameter can be modified if we implement more sophisticated logic in the future).
  1. If you don't follow anyone, you are shown a list of user recommendations (with logic in the backend but at the moment it is random)
Screenshot 2023-12-04 at 10 12 49
1.	Login Check for Buttons: Please ensure that the ‘for you’ and ‘following’ buttons are not displayed when the user is not logged in. This is crucial for proper user experience and privacy.
2.	Responsive Design: There needs to be consistent spacing between the navbar and the ‘for you/following’ buttons across different devices. Let’s make sure the layout remains responsive.
3.	Empty Following List: When a user’s following list is empty, please display an informative message. Then, below that message show the discovery users list.
4.	Following Page Message: The message displayed on the ‘following’ page when a user is not following anyone needs to be revised for clarity.
5.	Profile Edit Option Post-Logout: Currently, the option to edit a profile is still visible after a user logs out from their own profile. This could potentially lead to errors. Let’s address this to ensure the edit option is hidden upon logout.

Copy link
Contributor

@BlessedLongsword BlessedLongsword left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone disagrees with my suggestions, speak up >:D.

By the way @guzmanalejandro please make profile pictures consistent through the app. To do this, make the div height and width equal and set the image to cover. You have an example of this in the KasulaNavbar.

src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
src/components/UserFeed.jsx Outdated Show resolved Hide resolved
@guzmanalejandro
Copy link
Contributor Author

UPDATE 14/12

  1. I have solved the conflicts with develop that were in the user feed component, now that component can be seen as a 'for you' recipe page in which you can filter, and when you change to 'following' the filters are the same allowing you to filter as well , an important change has been that now these two lists of recipes are the same and are constantly updated depending on which tab you have selected.
Screenshot 2023-12-14 at 20 19 19
  1. A follow button has been added to each user in the following and followers lists of each profile, allowing the user (must be logged in) to easily follow and unfollow each user.
Screenshot 2023-12-14 at 20 20 28
  1. The option to edit recipes has finally been implemented, if you are in your user profile, now on the pencil button in each recipe, if you press it, it opens a modal similar to a post recipe in which you can edit all the fields of the recipe (including the image) and update the recipe, updating the list of your recipes instantly.
Screenshot 2023-12-14 at 20 21 42 Screenshot 2023-12-14 at 20 21 08
  1. Minor changes have been made in order to satisfy all acceptance criteria of both US10 and US14. It is also worth noting that the AC2 of the US10 has been finalized in the US14 branch for convenience reasons, but when merging it should not pose any conflict problems.

@xvxnoah
Copy link
Contributor

xvxnoah commented Dec 14, 2023

Amazing job Alejandro!

@guzmanalejandro guzmanalejandro changed the title Feature/us14 follow user Feature/us10 user profile + us14 follow user Dec 14, 2023
@guzmanalejandro guzmanalejandro merged commit 0b5e4c0 into develop Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants