Updates to Tsuut'ina paradigm layouts and POS labels #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts of paradigms from Bruce Starlight
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 76.88% 76.88%
=======================================
Files 157 157
Lines 5746 5746
Branches 627 627
=======================================
Hits 4418 4418
Misses 1179 1179
Partials 149 149 ☔ View full report in Codecov by Sentry. |
fbanados
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'srs-updated-layouts' branch provides an updated set of paradigm layout definitions for Gunáhà (srseng), bringing those in line with the linguistic features of the set of paradigms provided by Bruce Starlight in 2024.
The bulk of these changes are centred on src/srseng/resources/layouts/, where 36 new paradigm layouts are defined in both 'basic' (imperfective-only) and 'full' (all possible aspects) forms. These should cover all of the combinations of argument structures, situation types (event vs. state), and conditions on subjects and objects reflected in the set of paradigms that Bruce provided. The corresponding set of labels (src/srseng/resources/altlabel.tsv) has been updated to reflect the text needed in these new layouts.
The remaining changes included in this pull request (a) bring the example importjson data in src/srseng/resources/dictionary/srseng_test_db.importjson up to date; and (b) fix a number of small settings (e.g., the tone marking used in Tsuut'ina word forms in the UI) for Gunáhà (src/srseng/site/settings.py).