Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Jwt에 있는 userId로 User 가져오는 util 구현 #64

Merged
merged 3 commits into from
Jul 17, 2023
Merged

[feat] Jwt에 있는 userId로 User 가져오는 util 구현 #64

merged 3 commits into from
Jul 17, 2023

Conversation

jiyeoon00
Copy link
Member

✒️ 관련 이슈번호

🔑 Key Changes

  1. Jwt에 있는 userId로 User 가져오는 util 구현
  2. gameService에 유저 아이디 1로 고정해 놓은 부분 수정

📢 To Reviewers

  • 요청한 유저 객체를 가져오고 싶은 경우 UserUtil의 getCurrentUser()를 호출하면 됩니다.

@jiyeoon00 jiyeoon00 requested a review from a team as a code owner July 15, 2023 20:57
@jiyeoon00 jiyeoon00 requested review from jinsu4755 and 2zerozu and removed request for a team July 15, 2023 20:57
@jiyeoon00 jiyeoon00 added feat 새로운 기능 추가 지연🐰 지연이가 작업함! labels Jul 15, 2023
@github-actions
Copy link

Unit Test Results

5 tests   5 ✔️  7s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 56d8803.

jinsu4755
jinsu4755 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@jinsu4755 jinsu4755 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 해당 부분 수정을 위해 필요하다고 하기 때문에 approve 하겠습니다 추후 더 좋은 방안이 있다면 고려해봅시다!

@jiyeoon00 jiyeoon00 merged commit 0393cce into develop Jul 17, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/userUtil branch July 17, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinsu4755 jinsu4755 jinsu4755 approved these changes

@2zerozu 2zerozu Awaiting requested review from 2zerozu 2zerozu is a code owner automatically assigned from U-is-Ni-in-Korea/server

Assignees

@jiyeoon00 jiyeoon00

Labels
feat 새로운 기능 추가 size/M 지연🐰 지연이가 작업함!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Jwt에 있는 userId로 User 가져오는 util 구현
2 participants
@jiyeoon00 @jinsu4755