[feat] 한판승부 생성하기 API 구현 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyeoon00
requested review from
jinsu4755 and
2zerozu
and removed request for
a team
2zerozu
approved these changes
Jul 12, 2023
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api") |
There was a problem hiding this comment.
game관련이면 /api/game으로 둬도 될거같은디
There was a problem hiding this comment.
애초에 컨트롤러 명 자체도 shortGame 이기 때문에 별도의 /game 에 대한 endpoint 를 다루지 않는다면
컨트롤러 이름과 매칭되는 역할과 endpoint Path 를 주면 좋을 것 같아요:)
| private final GameService gameService; | ||
|
|
||
| @PostMapping("/game/short") | ||
| public CreateShortGameResponseDto createShortGame(@RequestBody @Valid final CreateShortGameRequestDto createShortGameRequestDto) { |
There was a problem hiding this comment.
오 나 @Valid 안 넣었다 .. 고맙습니다
근데 바디도 final로 넣어야하나 ..???
| @@ -4,7 +4,7 @@ | |||
| import java.util.Objects; | |||
|
|
|||
| public enum GameResult { | |||
| WIN, LOSE, DRAW; | |||
| WIN, LOSE, DRAW, UNDECIDED; | |||
|
|
||
| public Game(Couple couple) { | ||
| this.couple = couple; | ||
| this.enable = Boolean.TRUE; |
| .build(); | ||
| } | ||
|
|
||
| @Transactional |
There was a problem hiding this comment.
이거 Service 맨위에 달아줬는데 여기서도 써야하나..?!
jinsu4755
approved these changes
Jul 12, 2023
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/api") |
There was a problem hiding this comment.
애초에 컨트롤러 명 자체도 shortGame 이기 때문에 별도의 /game 에 대한 endpoint 를 다루지 않는다면
컨트롤러 이름과 매칭되는 역할과 endpoint Path 를 주면 좋을 것 같아요:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers