-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Entity #17
Merged
Merged
feat: Add Entity #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyeoon00
requested review from
jinsu4755 and
2zerozu
and removed request for
a team
July 5, 2023 18:25
2zerozu
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ^__________^
MatchType, MatchResult, SnsType 에 대한 각각 Enum 값을 DB에 String으로 저장하기 위해 보다 효율이 좋다는 Convertor 사용 하는 방식을 적용
match가 mysql 예약어라 발생하는 문제로 인해 모든 테이블에서 match 단어를 game으로 변경하여 오해를 줄입니다. 추가로 join 관계에 대해 다른 방안을 만들기 위해서 일단 id 를 들고있을 수 있도록 변경합니다
유저 정보 저장시 sns 정보를 통해 만들어지는지 테스트
복잡한 join 관계에 대해서 query 사용을 위한 dsl 추가
유저의 닉네임을 수정할 수 있다. 유저의 닉네임은 10자를 넘을 수 없다.
jpa 연관 관계 매핑하여 수정 Co-authored-by: jiyeon <[email protected]> Co-authored-by: 이빵주 <[email protected]>
2zerozu
added
feat
새로운 기능 추가
pull request🔥
Good for newcomers
진수🦂
진수가 작업함!
지연🐰
지연이가 작업함!
영주🐼
영주가 작업함!
labels
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✒️ 관련 이슈번호
🔑 Key Changes
📢 To Reviewers