Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Entity #17

Merged
merged 14 commits into from
Jul 7, 2023
Merged

feat: Add Entity #17

merged 14 commits into from
Jul 7, 2023

Conversation

jiyeoon00
Copy link
Member

✒️ 관련 이슈번호

  • Closes #

🔑 Key Changes

📢 To Reviewers

@jiyeoon00 jiyeoon00 requested a review from a team as a code owner July 5, 2023 18:25
@jiyeoon00 jiyeoon00 requested review from jinsu4755 and 2zerozu and removed request for a team July 5, 2023 18:25
@2zerozu 2zerozu added this to the [앱잼] 서버 개발 🛠️ milestone Jul 5, 2023
Copy link
Collaborator

@2zerozu 2zerozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^__________^

jiyeoon00 and others added 8 commits July 6, 2023 03:29
MatchType, MatchResult, SnsType 에 대한 각각 Enum 값을 DB에 String으로 저장하기 위해 보다
효율이 좋다는 Convertor 사용 하는 방식을 적용
match가 mysql 예약어라 발생하는 문제로 인해 모든 테이블에서 match 단어를 game으로 변경하여 오해를 줄입니다.

추가로 join 관계에 대해 다른 방안을 만들기 위해서 일단 id 를 들고있을 수 있도록 변경합니다
유저 정보 저장시 sns 정보를 통해 만들어지는지 테스트
복잡한 join 관계에 대해서 query 사용을 위한 dsl 추가
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Unit Test Results

5 tests   5 ✔️  7s ⏱️
1 suites  0 💤
1 files    0

Results for commit b1f6869.

♻️ This comment has been updated with latest results.

jinsu4755 and others added 3 commits July 7, 2023 04:25
유저의 닉네임을 수정할 수 있다.
유저의 닉네임은 10자를 넘을 수 없다.
jpa 연관 관계 매핑하여 수정

Co-authored-by: jiyeon <[email protected]>
Co-authored-by: 이빵주 <[email protected]>
@2zerozu 2zerozu added feat 새로운 기능 추가 pull request🔥 Good for newcomers 진수🦂 진수가 작업함! 지연🐰 지연이가 작업함! 영주🐼 영주가 작업함! labels Jul 6, 2023
@jinsu4755 jinsu4755 merged commit e36015f into develop Jul 7, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/json branch July 7, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 추가 pull request🔥 Good for newcomers size/XL 영주🐼 영주가 작업함! 지연🐰 지연이가 작업함! 진수🦂 진수가 작업함!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants