Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#14 [feat] Spring Rest Controller Advice 구현 #16
#14 [feat] Spring Rest Controller Advice 구현 #16
Changes from all commits
3fe32ca
6d47193
4cccfc2
c79f691
5acb8f8
80a73cd
daeb577
11453e7
3eb1ba9
0880c18
dc8b228
51e9933
1fb09d4
de3c3de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BadRequestException, ConflictException, NotFoundException, UnauthorizedException 모두 ErrorType을 매개변수로 받아 ApiException에 넘겨주는 똑같은 역할을 하는데, 나눠서 커스텀 예외를 생성하신 이유가 궁금합니다...!
좀 더 명시적으로 어떤 관련 에러인지 보여주기 위함일까요...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네!
의 이유로 따로 나눴습니다