Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix deciding winner logic #139

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: Fix deciding winner logic #139

merged 1 commit into from
Dec 11, 2023

Conversation

jiyeoon00
Copy link
Member

✒️ 관련 이슈번호

  • Closes #

🔑 Key Changes

📢 To Reviewers

  • 승부 최종 결과 계산 시, 승자 설정 로직 수정

@jiyeoon00 jiyeoon00 requested a review from a team as a code owner December 11, 2023 16:56
@jiyeoon00 jiyeoon00 requested review from jinsu4755 and 2zerozu and removed request for a team December 11, 2023 16:56
Copy link

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit fdce987.

@@ -252,7 +252,6 @@ private User decideFinalGameScore(RoundMission myRoundMission, RoundMission part
myRoundMission.updateFinalResult(DRAW);
partnerRoundMission.updateFinalResult(DRAW);
}
winner = partnerRoundMission.getUser();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 사소한 부분 잘 찾았네요... 고생하셨습니다~

@jiyeoon00 jiyeoon00 merged commit d369da8 into develop Dec 11, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/finalGameScore branch December 11, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants