Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

커플 연결 관련 수정 #127

Merged
merged 3 commits into from
Sep 9, 2023
Merged

커플 연결 관련 수정 #127

merged 3 commits into from
Sep 9, 2023

Conversation

jiyeoon00
Copy link
Member

✒️ 관련 이슈번호

🔑 Key Changes

  1. 커플 코드 입력 시 이미 커플이 성사된 경우라면 에러 처리
  2. 실수로 되어버린 경우를 대비해 커플 끊기 API추가

📢 To Reviewers

  • 현재 한 user가 커플을 끊을 경우 다른 user의 couple도 null값이 된다. 상대방이 커플 끊을 경우 남겨진 사람은 어떻게 해야 할 지에 대한 플로우에 따라 처리가 필요할 거 같다.

@jiyeoon00 jiyeoon00 self-assigned this Sep 9, 2023
@jiyeoon00 jiyeoon00 requested a review from a team as a code owner September 9, 2023 07:02
@jiyeoon00 jiyeoon00 requested review from jinsu4755 and 2zerozu and removed request for a team September 9, 2023 07:02
@github-actions
Copy link

github-actions bot commented Sep 9, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 75d3cc2.

♻️ This comment has been updated with latest results.

jinsu4755
jinsu4755 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@jinsu4755 jinsu4755 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴다 역시 실질적 리드다 리드

src/main/java/com/universe/uni/service/CoupleService.java Outdated
final User user = userRepository.findById(userId)
.orElseThrow(() -> new BadRequestException(ErrorType.USER_NOT_EXISTENT));
user.connectCouple(couple);

}

private void validateIfCoupleConnected(Couple couple) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커플연결검증 정도로 validateCoupleConnexted정도로 해도 좋을 것 같아요~

@jiyeoon00 jiyeoon00 merged commit 39c5364 into develop Sep 9, 2023
8 checks passed
@jinsu4755 jinsu4755 deleted the feature/#126-coupleConnection branch September 13, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinsu4755 jinsu4755 jinsu4755 approved these changes

@2zerozu 2zerozu Awaiting requested review from 2zerozu 2zerozu is a code owner automatically assigned from U-is-Ni-in-Korea/server

Assignees

@jiyeoon00 jiyeoon00

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 커플 연결 관련 수정사항
2 participants
@jiyeoon00 @jinsu4755