Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(111): Separate game creation function #112

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jinsu4755
Copy link
Member

✒️ 관련 이슈번호

🔑 Key Changes

기본적으로 게임 생성 부 관련하여 전체적인 함수 분리를 진행하였습니다.
해당 부분 문제가 없다 생각된다면 담당자가 머지 후 작업 들어가 주세요!
@jiyeoon00

📢 To Reviewers

  • @jiyeoon00 기존 로직에 대해 수정 시 발생한 문제가 없는지 체크해주세요..! 동작은 동일하게 되도록 코드 수정을 따로 하진 않았으나 발생할 문제가 보인다면 이야기 해주세요 :)

@jinsu4755 jinsu4755 added feat 새로운 기능 추가 진수🦂 진수가 작업함! labels Aug 23, 2023
@jinsu4755 jinsu4755 added this to the [Release] Server milestone Aug 23, 2023
@jinsu4755 jinsu4755 requested a review from a team as a code owner August 23, 2023 10:24
@jinsu4755 jinsu4755 requested review from jiyeoon00 and 2zerozu and removed request for a team August 23, 2023 10:24
@github-actions
Copy link

Unit Test Results

5 tests   5 ✔️  8s ⏱️
1 suites  0 💤
1 files    0

Results for commit 572a5b4.

Copy link
Member

@jiyeoon00 jiyeoon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다아

@jiyeoon00 jiyeoon00 merged commit 0df2a09 into develop Aug 24, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/111-create-game branch August 24, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 새로운 기능 추가 size/L 진수🦂 진수가 작업함!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 게임 생성 로직 함수 분리
2 participants