Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#91 / 히스토리 리팩토링, 로딩뷰 #97

Merged
merged 8 commits into from
Sep 2, 2023

Conversation

l2zh
Copy link
Member

@l2zh l2zh commented Sep 1, 2023

📌 관련 이슈

📷 screenshot

2023-09-01.3.27.21.mov

📝 Work Desciption

  • 히스토리 부분 리팩토링
  • UiState 적용
  • 스켈레톤 로딩뷰 구현

📚 Reference 혹은 궁금한 사항들

  • 시연영상은 확인용으로 delay 줘서 찍었습니당

@l2zh l2zh added feat 구현 및 개선 refactoring 리팩토링 Pull Request 🔥 풀리퀘 날림 준희 🦝 유니의 래퍼 담당 labels Sep 1, 2023
@l2zh l2zh added this to the 릴리즈 중간 공유 milestone Sep 1, 2023
@l2zh l2zh requested a review from a team September 1, 2023 06:44
@l2zh l2zh self-assigned this Sep 1, 2023
Copy link
Contributor

@taeheeL taeheeL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구비구비

Comment on lines +116 to +117
//shimmer-android
implementation "com.facebook.shimmer:shimmer:0.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

심야?

@@ -104,5 +104,93 @@

</androidx.constraintlayout.widget.ConstraintLayout>

<com.facebook.shimmer.ShimmerFrameLayout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런식으로 쓰는거구만요 호오

@l2zh l2zh merged commit 2cf1672 into develop Sep 2, 2023
1 check passed
@l2zh l2zh deleted the feature/#91-history-refactoring branch September 2, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현 및 개선 Pull Request 🔥 풀리퀘 날림 준희 🦝 유니의 래퍼 담당 refactoring 리팩토링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants