Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#52 / 기념일 서버통신 & 로직 구현 완료 #66

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Jul 19, 2023

📌 관련 이슈

📷 screenshot

default.mp4

📝 Work Desciption

  • max date 로컬 date에서 받아서 업데이트
  • DateUtill 사용해서 기념일 포멧팅한 다음 서버에 보내서 200 받음

📚 Reference 혹은 궁금한 사항들

  • 닉네임 로직 수정 추후에 파서 할게유

@taeheeL taeheeL added feat 구현 및 개선 Pull Request 🔥 풀리퀘 날림 태희 🦊 유니의 대장 담당 labels Jul 19, 2023
@taeheeL taeheeL added this to the Phase3 milestone Jul 19, 2023
@taeheeL taeheeL requested a review from a team July 19, 2023 09:51
@taeheeL taeheeL self-assigned this Jul 19, 2023
@taeheeL taeheeL changed the title Feature/#52 set startdate #52 / 기념일 서버통신 & 로직 구현 완료 Jul 19, 2023
Copy link
Member

@sub101 sub101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 굿이에요~👍🏻👍🏻


object DateUtil {
fun formatedMonth(month: Int) =
if (month <= 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (month <=0 || month > 12)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13월의 금요일

Comment on lines +28 to +31
val formatedDate =
binding.dpDDay.year.toString() + "-" + DateUtil.formatedMonth(binding.dpDDay.month) + "-" + DateUtil.formatedDay(
binding.dpDDay.dayOfMonth,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 좋은거 있으면 유틸로 빼~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빼줘잉

@taeheeL taeheeL merged commit cb06b9d into develop Jul 19, 2023
1 check passed
@taeheeL taeheeL deleted the feature/#52-set-startdate branch July 19, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현 및 개선 태희 🦊 유니의 대장 담당 Pull Request 🔥 풀리퀘 날림
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[온보딩] 기념일 설정하기 서버통신 및 로직 점검
3 participants