#19,47 / 소원권 ui & 로직 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeheeL
approved these changes
Jul 19, 2023
| import sopt.uni.databinding.ActivityWishBinding | ||
| import sopt.uni.util.binding.BindingActivity | ||
|
|
||
| class WishActivity : BindingActivity<ActivityWishBinding>(R.layout.activity_wish) { | ||
|
|
||
| private lateinit var multiviewAdapter: WishMultiviewAdapter |
There was a problem hiding this comment.
어뎁터 객체를 생성했으면 꼭 onDestroy에 null 처리를 해줘야 메모리 릭이 나지 않습니다!
Comment on lines
80
to
81
| val intent = Intent(this, WishFcActivity::class.java) | ||
| startActivity(intent) |
There was a problem hiding this comment.
우리에겐 확장함수가 있으니 사용하시면 편하실거에유
| (holder as MultiViewWishHolder1).bind(datas[position]) | ||
| when (holder) { | ||
| is MultiViewWishHolder1 -> { | ||
| holder.bind(datas[position]) | ||
| holder.setIsRecyclable(false) |
There was a problem hiding this comment.
RecyclerView의 각 아이템에 해당하는 데이터를 ViewHolder에 바인딩하고, 클릭 이벤트 처리하는 메소드인데 서버연결하면서 수정할것 같아용
Comment on lines
22
to
34
| // with(binding) { | ||
| // dialogTitle.setText(getString(R.string.use_wish_dialog_title)) | ||
| // dialogBody.setText(getString(R.string.use_wish_dialog_description)) | ||
| // btnRight.setText(getString(R.string.dialog_ok_text)) | ||
| // btnLeft.setOnSingleClickListener { | ||
| // dismiss() | ||
| // } | ||
| // btnRight.setOnSingleClickListener { | ||
| // val fragment = WishUsedFragment() | ||
| // parentFragmentManager.beginTransaction() | ||
| // .replace(R.id.fcv_wish_fc, fragment).commit() | ||
| // } | ||
| // } |
| import sopt.uni.R | ||
| import sopt.uni.databinding.FragmentWishUseMyBinding | ||
|
|
||
| class WishUseMyFragment : Fragment() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
#19, #49
📷 screenshot
2023-07-19.2.37.12.mov
📝 Work Desciption
📚 Reference 혹은 궁금한 사항들
�- edittext 엔터 처리 부분 추후에 다시 해야할 것 같습니다.