Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#48 / 닉네임 로직 & 서버 통신 구현 #59

Merged
merged 14 commits into from
Jul 18, 2023

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Jul 18, 2023

📌 관련 이슈

📷 screenshot

default.mp4

📝 Work Desciption

  • 글자 수에 따라 box stroke, helper text 변경했습니다
  • BindingAdaptor 사용했슴둥
  • 서버통신 200
  • AuthInterceptor 조금 수정했슴둥

📚 Reference 혹은 궁금한 사항들

@taeheeL taeheeL added feat 구현 및 개선 Pull Request 🔥 풀리퀘 날림 태희 🦊 유니의 대장 담당 labels Jul 18, 2023
@taeheeL taeheeL added this to the Phase3 milestone Jul 18, 2023
@taeheeL taeheeL requested a review from a team July 18, 2023 18:23
@taeheeL taeheeL self-assigned this Jul 18, 2023
Copy link
Contributor

@rkdmf1026 rkdmf1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 5 to 20
val onBoardingList = listOf<OnBoardingItem>(
OnBoardingItem(
image = R.drawable.ic_onboarding,
image = R.drawable.onboarding1,
title = "다양한 카테고리의 미션을 함께 즐겨보세요",
description = "연인의 새로운 매력을 발견할 수 있어요",
),
OnBoardingItem(
image = R.drawable.ic_onboarding,
image = R.drawable.onboarding2,
title = "장기 승부와 한판 승부를 선택할 수 있어요",
description = "설렘 가득 짜릿한 승부를 진행해 보세요",
),
OnBoardingItem(
image = R.drawable.ic_onboarding,
image = R.drawable.onboarding3,
title = "승부를 통해 우리 둘만의 소원권을 생성해보세요",
description = "소중한 추억을 만들고 기록할 수 있어요",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 3개라서 애매하긴한데 좀 더 많으면 resource array로 반복문 돌려서 넣는거 해도 될듯??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋네요 감삼둥

Comment on lines +31 to +33
android:layout_width="@dimen/on_boarding_image"
android:layout_height="@dimen/on_boarding_image"
android:layout_marginHorizontal="16dp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나는 dimen으로 나중에 뺄게....

@taeheeL taeheeL merged commit 3f90257 into develop Jul 18, 2023
1 check passed
@taeheeL taeheeL deleted the feature/#48-post-nickname branch July 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현 및 개선 태희 🦊 유니의 대장 담당 Pull Request 🔥 풀리퀘 날림
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[온보딩] 닉네임 입력하기 서버통신
2 participants