#35 한판승부생성 화면전환 기능 구현 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
나가기 다이얼로그 기능 구현 한판승부 생성 기능 구현 미션상세 이동 기능 구현
rkdmf1026
force-pushed
the
feature/#35-createshortgame-function
branch
from
3035611
to
3d2406e
Compare
taeheeL
approved these changes
Jul 18, 2023
| viewModel.missionList.observe(this) { | ||
| missionAdapter.submitList(it) | ||
| } | ||
| viewModel.isCreateSuccess.observe(this) { | ||
| if (it == true) { |
There was a problem hiding this comment.
Suggested change
| if (it == true) { | |
| if (it) { |
이렇게 바꿔도 되지 않나욤?
| @@ -89,7 +151,7 @@ class CreateShortGameActivity : | |||
| @JvmStatic | |||
| @BindingAdapter("setContentLength") | |||
| fun setContentLength(view: TextView, length: Int) { | |||
| if (length >= MAX_LENGTH) { | |||
| if (length > MAX_LENGTH) { | |||
Comment on lines
+24
to
+59
| titleText?.let { | ||
| binding.dialogTitle.visibility = View.VISIBLE | ||
| binding.dialogTitle.text = it | ||
| } ?: kotlin.run { | ||
| binding.dialogTitle.visibility = View.GONE | ||
| } | ||
| bodyText?.let { | ||
| binding.dialogBody.visibility = View.VISIBLE | ||
| binding.dialogBody.text = it | ||
| } ?: kotlin.run { | ||
| binding.dialogBody.visibility = View.GONE | ||
| } | ||
| confirmButtonText?.let { | ||
| binding.btnRight.text = it | ||
| } | ||
| dismissButtonText?.let { | ||
| binding.btnLeft.text = it | ||
| } | ||
|
|
||
| confirmClickListener?.let { | ||
| binding.btnRight.visibility = View.VISIBLE | ||
| binding.btnRight.setOnClickListener { | ||
| confirmClickListener?.invoke() | ||
| } | ||
| } ?: kotlin.run { | ||
| binding.btnRight.visibility = View.GONE | ||
| } | ||
|
|
||
| dismissClickListener?.let { | ||
| binding.btnLeft.visibility = View.VISIBLE | ||
| binding.btnLeft.setOnClickListener { | ||
| dismissClickListener?.invoke() | ||
| } | ||
| } ?: run { | ||
| binding.btnLeft.visibility = View.GONE | ||
| } |
| import sopt.uni.presentation.entity.MissionIdPosition | ||
|
|
||
| class MissionDetailCreateViewModel(savedStateHandle: SavedStateHandle) : ViewModel() { | ||
| val missionId = savedStateHandle.get<MissionIdPosition>(MissionDetailCreateActivity.MISSION_ID_POSITION) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
closed #35
📷 screenshot
KakaoTalk_20230718_231731588.mp4
📝 Work Desciption
📚 Reference 혹은 궁금한 사항들
다이얼로그 재사용할 수 있게 만들어둔거 나중에 설명드릴게