-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#32 / dialog custom #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeheeL
force-pushed
the
feature/#32-dialog-custom
branch
from
July 15, 2023 05:08
01d8ce4
to
9d957ba
Compare
taeheeL
approved these changes
Jul 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굿!
app/src/main/AndroidManifest.xml
Outdated
@@ -88,16 +88,16 @@ | |||
|
|||
<activity | |||
android:name=".presentation.MissionDetailCreateActivity" | |||
android:exported="false" | |||
android:exported="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
false!
import androidx.databinding.ViewDataBinding | ||
import androidx.fragment.app.DialogFragment | ||
|
||
abstract class BindingDialogFragment<B : ViewDataBinding>(@LayoutRes private val layoutRes: Int) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아주 좋다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📷 screenshot
2023-07-15.2.45.30.mov
📝 Work Desciption
📚 Reference 혹은 궁금한 사항들
혹시 이렇게 하는게 아니면 말해주세요..!