Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#32 / dialog custom #37

Merged
merged 5 commits into from
Jul 15, 2023
Merged

#32 / dialog custom #37

merged 5 commits into from
Jul 15, 2023

Conversation

l2zh
Copy link
Member

@l2zh l2zh commented Jul 14, 2023

📌 관련 이슈

📷 screenshot

2023-07-15.2.45.30.mov

📝 Work Desciption

  • 다이얼로그 뷰 그리기 (기본 뷰 4종류, datepicker 다이얼로그)
  • 바인딩 프레그먼트 다이얼로그 확장함수 구현

📚 Reference 혹은 궁금한 사항들

혹시 이렇게 하는게 아니면 말해주세요..!

@l2zh l2zh added feat 구현 및 개선 UI UI 작업 Pull Request 🔥 풀리퀘 날림 준희 🦝 유니의 래퍼 담당 labels Jul 14, 2023
@l2zh l2zh added this to the Phase2 milestone Jul 14, 2023
@l2zh l2zh requested a review from a team July 14, 2023 17:50
@l2zh l2zh self-assigned this Jul 14, 2023
Copy link
Contributor

@taeheeL taeheeL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿!

@@ -88,16 +88,16 @@

<activity
android:name=".presentation.MissionDetailCreateActivity"
android:exported="false"
android:exported="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false!

import androidx.databinding.ViewDataBinding
import androidx.fragment.app.DialogFragment

abstract class BindingDialogFragment<B : ViewDataBinding>(@LayoutRes private val layoutRes: Int) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아주 좋다!

@taeheeL taeheeL merged commit 28cd371 into develop Jul 15, 2023
1 check passed
@l2zh l2zh changed the title Feature/#32 dialog custom #32 / dialog custom Jul 15, 2023
@taeheeL taeheeL deleted the feature/#32-dialog-custom branch July 15, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 구현 및 개선 Pull Request 🔥 풀리퀘 날림 준희 🦝 유니의 래퍼 담당 UI UI 작업
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants