Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa/#178 shortgame #179

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Qa/#178 shortgame #179

merged 4 commits into from
Dec 20, 2023

Conversation

rkdmf1026
Copy link
Contributor

๐Ÿ“Œ ๊ด€๋ จ ์ด์Šˆ

closed #178

๐Ÿ“ท screenshot

์Œ

๐Ÿ“ Work Desciption

  • ๋ฏธ์…˜ ์นดํ…Œ๊ณ ๋ฆฌ ๊ณต๋žตํŒ ๋ถ€๋ถ„ ์ค„๋ฐ”๊ฟˆ ์ˆ˜์ •
  • ๊ธ€์ž ์ˆ˜ ์ดˆ๊ณผ ์ƒํƒœ์—์„œ ๋ฏธ์…˜ ์นดํ…Œ๊ณ ๋ฆฌ ์„ ํƒ ์‹œ, ๋ฉ”์‹œ์ง€ ์ถœ๋ ฅ
  • ๋ฏธ์…˜ ์นดํ…Œ๊ณ ๋ฆฌ ์„ ํƒํ•˜๊ธฐ ์–‘ ์˜† dp๋ฐ ์ œ์•ฝ ์ˆ˜์ •
  • ๊ธ€์ž ์ˆ˜ ์ดˆ๊ณผ ์ƒํƒœ์—์„œ ๋’ค๋กœ๊ฐ€๊ธฐ ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ๋ฐ ui state๋กœ ๋ณ€๊ฒฝ
  • ์ง„ํ–‰์ค‘ ๊ณต๋žตํŒ ์™ผ์ชฝ์ •๋ ฌ๋กœ ์ˆ˜์ •

๐Ÿ“š Reference ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

ํ•œํŒ์Šน๋ถ€ ์†Œ์› ์ž‘์„ฑํ•˜๊ธฐ ์†Œ์›๊ถŒ ํ‹ฐ์ผ“ ๋ฐ˜์‘ํ˜•์œผ๋กœ ์ œ์•ฝ ๊ฑธ๊ธฐ
์–˜๋Š” ๋””์ž์ด๋„ˆํ•˜๊ณ  ์ด์•ผ๊ธฐํ•ด๋ณด๊ณ  ๋‹ค๋ฅธ ํ”ผ์•Œ์— ์˜ฌ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค.

๋’ค๋กœ๊ฐ€๊ธฐ๊ฐ€ ์•ˆ๋จนํ˜”๋˜ ์ด์œ ๋Š” ๋‹ค์Œ๊ณผ ๊ฐ™์Šต๋‹ˆ๋‹ค.

  1. ๊ฐ ํ”„๋ž˜๊ทธ๋จผํŠธ์—์„œ ์•กํ‹ฐ๋น„ํ‹ฐ์˜ onBackPressdCallback์„ ์‚ฌ์šฉํ•˜์—ฌ ๋’ค๋กœ๊ฐ€๊ธฐ๋ฅผ ์ •์˜ํ•ฉ๋‹ˆ๋‹ค.
  2. ํ”„๋ž˜๊ทธ๋จผํŠธ ์ „ํ™˜์„ replace๋กœ ํ•˜๋ฉด ๋งค๋ฒˆ ์ƒ๋ช…์ฃผ๊ธฐํ•จ์ˆ˜๋ฅผ ํ†ตํ•ด ๊ฐ ํ”„๋ž˜๊ทธ๋จผํŠธ์˜ ๋’ค๋กœ๊ฐ€๊ธฐ๊ฐ€ ์ •์˜๋˜์ง€๋งŒ show, hide๋ฅผ ์‚ฌ์šฉํ•˜๋ฉด ์ƒ๋ช…์ฃผ๊ธฐ ํ•จ์ˆ˜๊ฐ€ ํ˜ธ์ถœ๋˜์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์— ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค.

@rkdmf1026 rkdmf1026 added fix ๋ฒ„๊ทธ ์ˆ˜ ๋™๊ธฐ ๐Ÿ ์œ ๋‹ˆ์˜ ์ •์‹ ์  ์ง€์ฃผ ๋‹ด๋‹น QA QA ๊ด€๋ จ ์ž‘์—… labels Dec 20, 2023
@rkdmf1026 rkdmf1026 requested a review from a team December 20, 2023 08:39
@rkdmf1026 rkdmf1026 self-assigned this Dec 20, 2023
Copy link
Contributor

@taeheeL taeheeL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตณ์ž…๋‹ˆ๋‹ค ๐Ÿ‘๐Ÿ‘

@taeheeL taeheeL merged commit ac60f60 into develop Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix ๋ฒ„๊ทธ ์ˆ˜ ๋™๊ธฐ ๐Ÿ ์œ ๋‹ˆ์˜ ์ •์‹ ์  ์ง€์ฃผ ๋‹ด๋‹น QA QA ๊ด€๋ จ ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] ํ•œํŒ์Šน๋ถ€ ๋ทฐ ์ด์Šˆ
2 participants