Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#169 / [QA] 닉네임 뷰 오류사항 수정 및 센트리 연결 #170

Merged
merged 2 commits into from
Dec 17, 2023
Merged

#169 / [QA] 닉네임 뷰 오류사항 수정 및 센트리 연결 #170

merged 2 commits into from
Dec 17, 2023

Conversation

taeheeL
Copy link
Contributor

@taeheeL taeheeL commented Dec 16, 2023

📌 관련 이슈

📷 screenshot

  • 기존 n / 10 이라고 되어있는 화면을 n / 5 로 수정하였습니다. 나중에 캡쳐본 넣을게요!

📝 Work Desciption

  • 피그마에 있는 최대 글자 수를 뷰에 반영했습니다. 이 부분을 놓쳤었네요.
  • 센트리를 연결하여 앞으로 네트워크나 안드로이드에서 발생하는 오류를 센트리에서 직접 확인할 수 있습니다. 생명주기에 따라 값과 상태를 모두 확인할 수 있으니 한번 사용해보시길 권장드려요!!

📚 Reference 혹은 궁금한 사항들

로그아웃 관련 이슈는 추후에 해결해서 해당 PR에 push 하겠습니다~

@taeheeL taeheeL added the QA QA 관련 작업 label Dec 16, 2023
@taeheeL taeheeL requested a review from a team December 16, 2023 16:19
@taeheeL taeheeL self-assigned this Dec 16, 2023
sub101
sub101 approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@sub101 sub101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿👍🏻👍🏻

@sub101 sub101 merged commit 3d873b9 into develop Dec 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sub101 sub101 sub101 approved these changes

Assignees

@taeheeL taeheeL

Labels
QA QA 관련 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taeheeL @sub101