#133 / 닉네임 조건 변경 반영 및 디바운스 수정 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📷 screenshot
default.mp4
📝 Work Desciption
상수화된 값을 사용하여 추후에 유지보수도 고려하였습니다.
변경된 조건 사항을 반영했습니다.
BindingAdapter를 사용하지 않고 삼항연산자로 분기처리 하였습니다.
실험을 계속하다보니, 조건들이 충족되지 않아 빨간색으로 바뀔 때 디바운스가 되면 어색하길래 뺐습니다. 현재 버튼 활성화에만 디바운스 300ms 가 적용되었습니다!
📚 Reference 혹은 궁금한 사항들