-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#102 refactor createshortgame #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+484 -481 ๊ฐ ์ข ์ฌํ๋ค์.. ์๋น ์ต๊ณ ใ
xml ํ์๋๋ผ ๊ณ ์์ด ๋ง์ผ์ญ๋๋ค.. ๋ฆฌ๋ทฐ ํ๋ฒ๋ง ๋ด์ฃผ์ธ์!
@SerialName("image") | ||
val image: String, | ||
@SerialName("recommendTime") | ||
val recommendTime: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ถ์ฒ ์๊ฐ์ด null์ผ ์๋ ์๋์..? ํ๊ฑฑ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ผ๋จ ์๋ฒ๊ฐ ๋ด๋ ค์ฃผ๋๊ฒ nullableํ๊ฒ ๋ด๋ ค์ค๋๋ค...ใ ใ
if (fragment.isAdded) { | ||
transaction.show(fragment) | ||
} else { | ||
transaction.add(R.id.fcv_create_short_game, fragment, tag) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace๊ฐ ์๋ hide & add ๋ฐฉ์์ ์ฌ์ฉํ ์ด์ ๊ฐ ์์๊น์? ๋ก์ง ์ค๋ช ํด์ฃผ์๋ฉด ๋๋ฌด๋๋ฌด ๊ฐ์ฌํ๊ฒ ์ต๋๋ค :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace์ add ์ฐจ์ด๋ฅผ ๋ณด์๋ฉด replace๋ ์ด์ ํ๋๊ทธ๋จผํธ๋ฅผ ์ญ์ ํ๊ณ ์๋ก์ด ํ๋๊ทธ๋จผํธ๋ฅผ ์ถ๊ฐํ๋ ๊ฒ๊ณผ ๋ฌ๋ฆฌ add์ ๊ฒฝ์ฐ์๋ ํ๋๊ทธ๋จผํธ๋ฅผ ์ญ์ ํ์ง์์ต๋๋ค. ํํ์น๋ถ์์ฑ์์ ๋ฏธ์ ์นดํ ๊ณ ๋ฆฌ๋ทฐ๋ก ์์ฃผ ์ด๋์ ํด์ผํ ๊ฑฐ๋ผ๊ณ ์๊ฐํด์ ๊ตณ์ด ๋งค๋ฒ ํ๋๊ทธ๋จผํธ๋ฅผ ์ญ์ ํ ํ์์๋ค๊ณ ์๊ฐํด์ ์ด๋ ๊ฒ ๊ตฌํํ์ต๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ ํฌ ์ํฉ์์๋ add๋ก show/hide๋ฅผ ํ๋ ๊ฒ ๋ง๊ฒ ๊ตฐ์..! ์ํ๋ฅผ ๋ณด์กดํด์ผ ๋๊ธฐ๋ ํ๋๊น
์ญ์ ์๋ถ์ง๊ฐ ์ต๊ณ ์ผ ใ
ใ
๊ฐ์ผ๋ฅ
private fun goToShortGame() { | ||
val activity = activity as CreateShortGameActivity | ||
activity.changeFragment(getString(R.string.label_short_game)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด๋ ๊ฒ ํ๋ฉด ์กํฐ๋นํฐ์ ํ๋๊ทธ๋จผํธ๊ฐ์ ๊ฐํ ์์กด์ฑ์ด ์๊ธธ ๊ฒ ๊ฐ์๋ฐ, ๋ค๋ฅธ State๋ Activity๋ด์์ ๋ถ๊ธฐ์ฒ๋ฆฌ๋ฅผ ํตํด ๋ณ๊ฒฝ์ํค๋ ๊ฑด ์ด๋จ๊น์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด ๋ถ๋ถ์ด ๊ฐ์ฅ ๊ณ ๋ฏผํ๋ ๋ถ๋ถ์ด๊ธดํ๋ฐ, ๋ฉ๋ชจ์ฅ ๊ธฐ๋ฅ ๊ตฌํํ๊ณ ์๊ฐ ์๊ธฐ๋ฉด ๊ฐ์ ํ๋๋ก ํ๊ฒ ์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viewmodel์ state๋ฅผ ๋๊ณ ์กํฐ๋นํฐ์์ ๊ด์ฐฐํด์ ์ ํํ๋ ์์ผ๋ก ํด๋ณด๊ฒ ์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋น ์ต๊ณ !
8070a0b
to
4e2ce03
Compare
๐ ๊ด๋ จ ์ด์
๐ท screenshot
default.mp4
๐ Work Desciption
๐ Reference ํน์ ๊ถ๊ธํ ์ฌํญ๋ค
์กํฐ๋นํฐ๋ทฐ๋ชจ๋ธ์ ์ฌ์ฉํด์ ํ๋์ ๋ทฐ๋ชจ๋ธ์ ๋ ํ๋๊ทธ๋จผํธ๊ฐ ๊ณต์ ํ๋ ์์ผ๋ก ๊ตฌ์กฐ๋ฅผ ๋ณ๊ฒฝํ์ต๋๋ค.