-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flatpak build #189
base: master
Are you sure you want to change the base?
Add flatpak build #189
Conversation
You might want to look at Aegisub#336. I'm working on a Flatpak package to be published in Flathub: https://github.com/zefr0x/flathub/tree/aegisub |
Your package seems much more sophisticated, but since the main work for Aegisub/Aegisub is done here, and with meson as build system, with the version of the libraries, that are used here, and this is eventually merged into that repo, it would be better to build on this repo, maybe we could merge the manifests in some way 🤔 |
I don't think that Flathub would accept a fork with no official stable release. Any way it's easy to use the new build system, noting huge need to be changed (I even have it commented in the manifest). If Flathub don't have any problems I will relay on TypesettingTools/Aegisub. I will ask them when I open a pull request. |
The only main difference between the meson and the autotools version is the flatpak specific things, like .desktop file with name (not aegisub but "org.aegisub.Aegisub") and the icons names, the rest is nearly the same, since I also used the native build systems for the dependencies, but not that many specific options etc. I also added Dependency control, which could be controversial. IMO it's much more concise, to modfiy a few lines of the build system than patching the original code up, to rename these etc. Meson is better integrated than autotools in the flatpak-builder etc. |
This provides a flatpak manifest to build aegisub as flatpak application