Fix Unicode strings for luaL_loadbuffer in Lua 5.0 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing truncated" This reverts commit b1ee428.
YoRyan
changed the title
lolleko
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular binding chops 14 characters from the end of the input string, corrupting the Lua payload it contains. Quite honestly, I have no idea why this behavior is happening. I first noticed it when attempting (and failing) to load TypescriptToLua's lualib bundle. We are calling the C wrapper directly, so maybe this is caused by an underlying issue with emscripten?For Lua 5.0, we need to manually convert from a UTF-16 Node string to a UTF-8 Lua string, as this doesn't seem to be automatic.The string buffer size should be Lua's UTF-8 length, not Node's UTF-16 length.