Skip to content

Export utilities using vitest via 'typir/test' #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Export utilities using vitest via 'typir/test' #68

merged 1 commit into from
Apr 8, 2025

Conversation

JohannesMeierSE
Copy link
Collaborator

@JohannesMeierSE JohannesMeierSE commented Apr 7, 2025 •
edited
Loading

Aims to fix this bug report by @montymxb

Seems there may be a vitest import in the src that’s being loaded up w/ the regular non-test code. This leads to an unexpected repeat crashing of the LS from what I can tell. [...] The file is in packages/typir/src/utils/test-utils.ts

Requires a patch release after merging.

For fast testing, I published next versions:

@JohannesMeierSE JohannesMeierSE added the bug Something isn't working label Apr 7, 2025
@JohannesMeierSE JohannesMeierSE added this to the v0.3 milestone Apr 7, 2025
@JohannesMeierSE JohannesMeierSE marked this pull request as ready for review April 8, 2025 10:11
montymxb
montymxb approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: looks good!

@JohannesMeierSE JohannesMeierSE removed the request for review from insafuhrmann April 8, 2025 14:41
@JohannesMeierSE JohannesMeierSE merged commit 2878862 into main Apr 8, 2025
3 checks passed
@JohannesMeierSE JohannesMeierSE deleted the jm/typir-test-vitest branch April 8, 2025 14:42
JohannesMeierSE added a commit that referenced this pull request Apr 9, 2025
@JohannesMeierSE
Export utilities using vitest via 'typir/test' (#68)
1436ca2
@JohannesMeierSE JohannesMeierSE modified the milestones: v0.3, v0.2 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montymxb montymxb montymxb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesMeierSE @montymxb