Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated enableAggregateAnalytics for consistent DX #309

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

munkiat
Copy link

@munkiat munkiat commented Jul 29, 2024

Set enableAggregate Analytics to False as default for the same analytics DX as Tyk's quick tutorials.

Added description that enableAggregateAnalytics to true will reduce the analytics set being sent

Description

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • Documentation updates or improvements.

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • I have manually updated the README(s)/documentation accordingly.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Set enableAggregate Analytics to False as default for the same analytics DX as Tyk's quick tutorials. 

Added description that enableAggregateAnalytics to true will reduce the analytics set being sent
@munkiat munkiat requested a review from a team as a code owner July 29, 2024 04:13
@munkiat munkiat requested review from olamilekan000 and removed request for a team July 29, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant