TT-10137 refactor: Remove TYK_GW_OPTIMISATIONSUSEASYNCSESSIONWRITE setting #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this is obsolete, see TykTechnologies/tyk-docs#3279
jakub-bochenski
requested review from
andrei-tyk
and removed request for
a team
buraksekili
approved these changes
Sep 27, 2023
caroltyk
changed the title
|
I don't think the test failures are related to this change. Can this be merged? |
|
@jakub-bochenski You are right. Tests failure are not related to your change. They are using secret which doesn't exists on your repo that's why they are failing. We merge the PR after QA test it. I will move your PR in the QA's backlog. Once we get green flag from QA we will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is obsolete, see TykTechnologies/tyk-docs#3279