CI test pr #24
Open
CI test pr #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3.10 fails 3.7 is still used
GitHub action 1
hpplyt
reviewed
Sep 19, 2022
|
|
||
| on: | ||
| push: | ||
| branches: [ "master" ] |
There was a problem hiding this comment.
Should this not be changed "ci-test" so that the CI triggers for PRs/pushes to that branch? (I can quickly do it after merging, just want to check before breaking something)
hpplyt
reviewed
Sep 19, 2022
| push: | ||
| branches: [ "master" ] | ||
| pull_request: | ||
| branches: [ "master" ] |
There was a problem hiding this comment.
I like having the tests on PRs run only for PRs into master, but again it is a personal preference and git usage question. Feel free to remove this or use '*' to indicate all branches. Here is the relevant docs from github: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #23 A PR into the
ci-testbranch