Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Implement Zulip's alerts #845

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Conversation

mehdibo
Copy link
Contributor

@mehdibo mehdibo commented Aug 26, 2024

Summary

Fixes #802

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@mehdibo mehdibo changed the title Zulip alert feat(alerting): Implement Zulip's alerts Aug 26, 2024
@mehdibo mehdibo marked this pull request as ready for review August 26, 2024 21:44
@mehdibo
Copy link
Contributor Author

mehdibo commented Aug 26, 2024

Here is a preview of the message sent (the last one is the one implemented):
https://chat.zulip.org/#narrow/stream/7-test-here/topic/Gatus

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

Could you also add the new provider here:

var (
// Validate interface implementation on compile
_ AlertProvider = (*awsses.AlertProvider)(nil)
_ AlertProvider = (*custom.AlertProvider)(nil)
_ AlertProvider = (*discord.AlertProvider)(nil)
_ AlertProvider = (*email.AlertProvider)(nil)
_ AlertProvider = (*github.AlertProvider)(nil)
_ AlertProvider = (*gitlab.AlertProvider)(nil)
_ AlertProvider = (*gitea.AlertProvider)(nil)
_ AlertProvider = (*googlechat.AlertProvider)(nil)
_ AlertProvider = (*jetbrainsspace.AlertProvider)(nil)
_ AlertProvider = (*matrix.AlertProvider)(nil)
_ AlertProvider = (*mattermost.AlertProvider)(nil)
_ AlertProvider = (*messagebird.AlertProvider)(nil)
_ AlertProvider = (*ntfy.AlertProvider)(nil)
_ AlertProvider = (*opsgenie.AlertProvider)(nil)
_ AlertProvider = (*pagerduty.AlertProvider)(nil)
_ AlertProvider = (*pushover.AlertProvider)(nil)
_ AlertProvider = (*slack.AlertProvider)(nil)
_ AlertProvider = (*teams.AlertProvider)(nil)
_ AlertProvider = (*telegram.AlertProvider)(nil)
_ AlertProvider = (*twilio.AlertProvider)(nil)
)

alerting/config.go Outdated Show resolved Hide resolved
alerting/provider/zulip/zulip.go Outdated Show resolved Hide resolved
alerting/provider/zulip/zulip.go Outdated Show resolved Hide resolved
@mehdibo mehdibo requested a review from TwiN August 30, 2024 15:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (54221ef) to head (777faf6).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
alerting/provider/zulip/zulip.go 93.22% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
+ Coverage   78.77%   78.95%   +0.18%     
==========================================
  Files          70       71       +1     
  Lines        4707     4767      +60     
==========================================
+ Hits         3708     3764      +56     
- Misses        792      794       +2     
- Partials      207      209       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TwiN TwiN added feature New feature or request area/alerting Related to alerting labels Sep 4, 2024
@TwiN
Copy link
Owner

TwiN commented Sep 4, 2024

@mehdibo Great work!

@TwiN TwiN merged commit d947a6b into TwiN:master Sep 4, 2024
1 check passed
@mehdibo mehdibo deleted the zulip-alert branch September 4, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert send to Zulip
3 participants