-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerting): custom alert support endpoint errors #844
feat(alerting): custom alert support endpoint errors #844
Conversation
…lerts - Updated `buildHTTPRequest` method in `AlertProvider` to accept a `result` parameter. - Added support for including `[ENDPOINT_ERRORS]` in both the request body and URL, which will be replaced by the errors from `Result.Errors[]`. - Adjusted `CreateExternalEndpointResult` to capture and store errors from query parameters. - This allows custom alerts to include detailed error information, enhancing the flexibility of alert notifications.
Hi @TwiN I've made the updates as per your suggestions. Could you please take another look? Thanks! |
hey, appreciate you work, i also really need this feature, how about to merge it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #844 +/- ##
==========================================
+ Coverage 78.96% 78.98% +0.01%
==========================================
Files 71 71
Lines 4768 4772 +4
==========================================
+ Hits 3765 3769 +4
Misses 794 794
Partials 209 209 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Summary
Fixes #840
buildHTTPRequest
method inAlertProvider
to accept aresult
parameter.[ENDPOINT_ERRORS]
in both the request body and URL, which will be replaced by the errors fromResult.Errors[]
.Send
method to pass theresult
object tobuildHTTPRequest
.CreateExternalEndpointResult
to capture and store errors from query parameters.Usage
push the status of an external endpoint
custom alerts config
Checklist
README.md
, if applicable.