Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logo on Login screen #834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

praveen-livspace
Copy link

Summary

Logo on the login screen is hardcoded. The proposed change uses the configured logo if available.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@praveen-livspace praveen-livspace changed the title Fix logo on Login screen fix: Logo on Login screen Aug 7, 2024
@TwiN
Copy link
Owner

TwiN commented Aug 29, 2024

Does that really make sense though?
I understand wanting to have to user logo on the page, but if there's an authentication page, wouldn't users want to know what they're authenticating to?

I'd be willing to meet in the middle and have some kind of <custom logo> | <Gatus' logo> design, but I feel just having the custom logo may be a bit confusing for the end user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants