Fix NullPointerException with deposit/withdraw methods #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a NullPointerException present in all deposit/withdraw methods in the Vault hook when a users has an unspecified amount of currency (generally 0). The account's currencies map will not contain an entry if the value is 0 or the currency otherwise doesn't exist, but no caution is exhibited with 0 balanced currencies.
Exception raised via VeinMiner as a proxy:
The
hasBalance()
was cautious, but VeinMiner was (incorrectly) callingwithdrawPlayer()
with an amount of 0, which is how this exception is raised. VeinMiner calling upon the economy's withdraw functions with 0 has been fixed separately, but I still feel that Funds can be more cautious about this :)