Skip to content

Added content encoding to the function that detects compressed sitema… #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added content encoding to the function that detects compressed sitema… #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/TurnerSoftware.SitemapTools/SitemapQuery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,10 @@ public async Task<IEnumerable<Uri>> DiscoverSitemapsAsync(string domainName, Can
return result;
}

private static bool IsCompressedStream(string contentType) =>
private static bool IsCompressedStream(string contentType, ICollection<string> contentEncoding) =>
contentType.Equals("application/x-gzip", StringComparison.InvariantCultureIgnoreCase) ||
contentType.Equals("application/octet-stream", StringComparison.InvariantCultureIgnoreCase);
contentType.Equals("application/octet-stream", StringComparison.InvariantCultureIgnoreCase) ||
contentEncoding.Contains("x-gzip");

/// <summary>
/// Retrieves a sitemap at the given URI, converting it to a <see cref="SitemapFile"/>.
Expand All @@ -149,9 +150,10 @@ private static bool IsCompressedStream(string contentType) =>
if (response.IsSuccessStatusCode)
{
var contentType = response.Content.Headers.ContentType.MediaType;
var contentEncoding = response.Content.Headers.ContentEncoding;
var requiresManualDecompression = false;
if (IsCompressedStream(contentType))

if (IsCompressedStream(contentType, contentEncoding))
{
requiresManualDecompression = true;
var baseFileName = Path.GetFileNameWithoutExtension(sitemapUrl.AbsolutePath);
Expand Down
Loading