-
Notifications
You must be signed in to change notification settings - Fork 226
Update to the [email protected] interface #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
ed6946c
update to match the [email protected] interface
Red-Portal a94269d
run formatter
Red-Portal a4711a9
run formatter
Red-Portal 3f8068b
run formatter
Red-Portal 222a638
run formatter
Red-Portal 57097f5
run formatter
Red-Portal a42eea8
run formatter
Red-Portal 798f319
run formatter
Red-Portal 69a4972
run formatter
Red-Portal cbcb8b5
run formatter
Red-Portal 081d6ff
remove plotting
Red-Portal a32a673
Merge branch 'update_advancedvi' of github.com:TuringLang/Turing.jl i…
Red-Portal 1bcec3e
fix formatting
Red-Portal b142832
fix formatting
Red-Portal 061ec35
fix formatting
Red-Portal 736bd3e
remove unused dependency
Red-Portal fd434d8
Merge branch 'update_advancedvi' of github.com:TuringLang/Turing.jl i…
Red-Portal 57108ee
Merge branch 'main' into update_advancedvi
yebai 8dc8067
Merge branch 'main' into update_advancedvi
yebai 297c32a
Update Project.toml
yebai 3010b5e
Merge branch 'main' of github.com:TuringLang/Turing.jl into update_ad…
Red-Portal 0c04434
fix make some arugments of vi initializer to be optional kwargs
Red-Portal 17a8290
Merge branch 'update_advancedvi' of github.com:TuringLang/Turing.jl i…
Red-Portal 626c5b5
remove tests for custom optimizers
Red-Portal cb2c618
remove unused file
Red-Portal 2b08a4b
Merge branch 'main' of github.com:TuringLang/Turing.jl into update_ad…
Red-Portal 0e496c4
Merge branch 'main' into update_advancedvi
yebai c1533a8
Update src/variational/bijectors.jl
yebai 231d6e2
Update Turing.jl
yebai c2ae04a
Merge branch 'main' of github.com:TuringLang/Turing.jl into update_ad…
Red-Portal 69639ec
fix remove call to `AdvancedVI.turnprogress`, which has been removed
Red-Portal ef9aeb1
apply comments from @yebai
Red-Portal 43c19aa
Merge branch 'update_advancedvi' of github.com:TuringLang/Turing.jl i…
Red-Portal cc18528
Update src/variational/VariationalInference.jl
yebai 162899a
Merge branch 'main' into update_advancedvi
yebai 0b79495
add old interface as deprecated
Red-Portal 3818152
bump AdvancedVI version
Red-Portal 91a9afe
add deprecation for `meanfield`
Red-Portal 12539aa
add `default_rng` interfaces
Red-Portal 0653bf1
add tests for variational inference
Red-Portal f74ec38
run formatter
Red-Portal 406824f
Merge branch 'main' of github.com:TuringLang/Turing.jl into update_ad…
Red-Portal f62e7b8
remove "src/variational/bijectors.jl" (moved to `DynamicPPL.jl`)
Red-Portal e3b7618
Merge remote-tracking branch 'origin/main' into update_advancedvi
yebai f0374b6
add more tests for variational inference initializer
Red-Portal 187a65c
remove non-essential reexports, fix tests
Red-Portal a5021d1
run formatter, rename functions
Red-Portal 218eb23
add documentation
Red-Portal 4714c3c
fix run formatter
Red-Portal f712755
fix remove debug commits
Red-Portal 8086398
run formatter
Red-Portal 37f6b06
run formatter
Red-Portal c717220
run formatter
Red-Portal e9f7f1e
add Variational submodule
Red-Portal 6a8c6ed
fix docstring style
Red-Portal c4d73fb
update docstring style
Red-Portal feb1a57
format docstring style
Red-Portal ea417fc
Merge branch 'breaking' into update_advancedvi
penelopeysm 4c9a538
fix typo
Red-Portal dfa8d20
fix use fixed seed with StableRNGs
Red-Portal a18f581
fix export variational families
Red-Portal f9528e0
fix forma
Red-Portal fb150c7
Merge branch 'main' into update_advancedvi
yebai 8174725
Merge remote-tracking branch 'origin/breaking' into update_advancedvi
penelopeysm dec108b
update changelog for advancedvi 0.4
Red-Portal b0d791e
fix version number
Red-Portal 29373ee
Format & add some links
penelopeysm d21e652
Merge branch 'breaking' into update_advancedvi
Red-Portal 4c72501
fix formatting
Red-Portal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# API: `Turing.Variational` | ||
|
||
```@autodocs | ||
Modules = [Turing.Variational] | ||
Order = [:type, :function] | ||
``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want these symbols to be exported when
using Turing
, or only whenusing Turing.Variational
?The table is only supposed to contain what gets brought into the namespace when
using Turing
, so technically, should only containvi
given the current code status. But, for these three exports that seem very unlikely to have name clashes with other things, it seems to me that we could actually just export them from Turing (or at least I don't see why not).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we combine
q_locationscale
,q_meanfield_gaussian
,q_fullrank_gaussian
methods into a single method, e.g.:q_distribution
, thenq_distribution(MvLocationScale, args...) = AdvancedVI.q_locationscale(args...)
q_distribution(DiagNormal, args...) = AdvancedVI.q_meanfield_gaussian(args...)
q_distribution(MvNormal, args...) = AdvancedVI.q_fullrank_gaussian(args...)
Here,
MvLocationScale
,DiagNormal
andMvNormal
are exported by Distributions via Turing. This would provide a unifiedq_distribution
interface for all variational families, and are extensible if needed.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yebai I am afraid this would complicate/confuse things a bit since
q_distribution(MvNormal, ...)
will not return anMvNormal
type but aMvLocationScale
type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@penelopeysm Thanks for the suggestion. I added the exports.