Skip to content

Conversation

@smallsaucepan
Copy link
Member

@smallsaucepan smallsaucepan commented Nov 16, 2025

NPM is recommending avoiding using NPM tokens for publishing, instead favouring trusted publishers (e.g. a particular github workflow). This change:

  • updates node versions (housekeeping)
  • adds the required configuration item to release workflow act as a trusted publisher in future
  • renames turf.yml to ci.yml to be more specific about what that workflow does

- "v*.*.*"

permissions:
id-token: write
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to configure a trusted publisher on npmjs? Otherwise I can dig into doing that.

strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [20.x, 22.x, 24.x]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen other packages consider dropping support for old versions of nodejs as a breaking change.
We aren't technically breaking support here, just not testing it which would make it more likely for a breaking change to sneak in.

I'm happy to either merge this as a non-major change, or push it off for later if you'd prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants