Marginally improve type checkability of code #2337
Open
+105
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
GarboMuffin
force-pushed
the
type-checking
branch
from
d0ca99d to
7daaaa4
Compare
GarboMuffin
added
pr: other
GarboMuffin
force-pushed
the
type-checking
branch
2 times, most recently
from
5cfca4d to
a0a8934
Compare
GarboMuffin
force-pushed
the
type-checking
branch
5 times, most recently
from
23bfc5f to
52d7f12
Compare
GarboMuffin
changed the title
GarboMuffin
force-pushed
the
type-checking
branch
14 times, most recently
from
2951fe5 to
ef60977
Compare
GarboMuffin
changed the title
GarboMuffin
force-pushed
the
type-checking
branch
from
b7e86b2 to
4d1ec08
Compare
GarboMuffin
force-pushed
the
type-checking
branch
from
4d1ec08 to
f9d755e
Compare
… webkit fullscreen
GarboMuffin
force-pushed
the
type-checking
branch
2 times, most recently
from
d9f6375 to
86cca4e
Compare
GarboMuffin
force-pushed
the
type-checking
branch
from
86cca4e to
6c47a2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2336 is an example of a bug that type checking would've stopped. To work towards adding type checking warnings, this PR adds a globals.d.ts defining some APIs that are missing from regular TypeScript and adjusts a few extensions to remove a few warnings.
If you read the extension changes, you should be able to convince yourself that this change has no affect on extension behavior and doesn't need any testing