Enhanced extension: Complexify!.js #2113

Kenay555 · 2025-05-09T01:04:19Z

A better extension for complex numbers, fixing all the issues with the original Complexity! See the first one at #2091
More motion, vectors, decimals and factorials**********!

*[Somehow not working]

A better extension for complex numbers, fixing all the issues with the original Complexity!

Kenay555 · 2025-05-09T01:05:02Z

What do you think, @Brackets-Coder and @yuri-kiss?

Brackets-Coder

Generally speaking you should try to follow formatting best practices so your code doesn't look cluttered. Additionally, try to avoid opening new pull requests when it isn't necessary and you could just update the original :)

Brackets-Coder · 2025-05-09T02:26:19Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

@@ -0,0 +1,1012 @@
+// Name: Complexify!
+// ID: kenayComplexify
+// Description: Complex Numbres in TurboWarp! Can you believe it?


Description has typos and should be more professional, targeted towards users. try something like "Complex Numerical Operations in TurboWarp." or something idk

makes sense

Brackets-Coder · 2025-05-09T02:27:10Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+	'use strict'; 
+//Just in case:
+if (!Scratch.extensions.unsandboxed) {
+  alert("We don't like sand");


Nice allusion to Anakin Skywalker's famous opinion, but generally you should avoid alerts and just throw the error

ok, i'll avoid alerts. also who's Anakin Skywalker?

ok, i'll avoid alerts. also who's Anakin Skywalker?

I'm just going to assume you've never watched the masterpiece of Star Wars

Brackets-Coder · 2025-05-09T02:28:54Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+    }
+}
+
+function jsCode() { /**Again, thanks Rawify*/


First, you're putting the library (which is already inside an Immediately Invoked Function Expression) inside a function that is just executed elsewhere, and you're also re-declaring "use-strict" again which is totally redundant. Why can't you just minify the library and put it inside the class constructor?

you're saying i can just insert the complex code in the constructor?

you're saying i can just insert the complex code in the constructor?

That's how JS works, if you're just executing the function once inside the try catch block than might as well not have the function and reduce line count

Brackets-Coder · 2025-05-09T02:31:24Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+		{
+		  filter: [Scratch.TargetType.SPRITE], //Just in case
+		  blockType: Scratch.BlockType.LABEL,
+		  text: Scratch.translate("Motion"),
+		},


so this section seems to be restricted to sprites, but let's check to make sure you're also filtering the block code so it doesn't return an error if these blocks are dragged from a sprite into the backdrop

I don't know how to do that, but i'll try

I don't know how to do that, but i'll try

You're correctly filtering the block pallet in the stage, but the sprite-exclusive blocks can be dragged into the stage and may cause errors. You should check to see if the block's target is the stage, it works like this:

blockOpcode({ Arg1, Arg2 }, { target }) { console.log(target); }

just console log target and you'll see how to detect the stage

ok i'll if (util.target.isStage) return; to each movement block

Brackets-Coder · 2025-05-09T02:32:03Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+		  filter: [Scratch.TargetType.SPRITE], 
+		  opcode: 'goToPolar', //A block no one asked for, and I fear no one needs
+		  blockType: Scratch.BlockType.COMMAND,
+		  text: 'Go polar [RADII] ∠ [ANGLY]',
+		  arguments: {
+			RADII: { type: Scratch.ArgumentType.STRING, defaultValue: 50 },
+			ANGLY: { type: Scratch.ArgumentType.STRING, defaultValue: '0.9272952180016123' }
+		  },
+		},
+		{
+		  filter: [Scratch.TargetType.SPRITE], 
+		  opcode: 'glideComplex', //My favourite block [I love it]
+		  blockType: Scratch.BlockType.COMMAND,
+		  text: 'Glide [SECS] secs to [COMPLEX]',
+		  arguments: {
+			COMPLEX: { type: Scratch.ArgumentType.STRING, defaultValue: '30+40i' },
+			SECS: { type: Scratch.ArgumentType.NUMBER, defaultValue: 1 }
+		  },
+		},


Are the offhand comments here really necessary? I think they just distract from the code

no, just some nice details. i'll delete them

Brackets-Coder · 2025-05-09T02:33:34Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+/**
+		We'll use toString() to return the Complex number with math notation. 
+		If you wonder why, remember Complex is a class, and hence, returns objects.
+		So, we don't want "{re: -5, im: 1}", "[-5,1]" or "[object Object]". We want "-5+i" as is
+  		Thus, no Scratch.Cast.toString() or anything like that, because toString() will always do.
+*/


May I ask why this is the case? If everything is returned as objects then shouldn't you just parse them and return their properties instead of the whole object? The reason Scratch.Cast.toString() exists is because scratch has weird quirks that it has to account for which the normal javascript toString doesn't

.toString can be used here, we know the value it returns is going to be a string cause it's toString, and since it's not a user inputted object (it's created from user input but that doesn't matter in this case) we don't have to care about using Cast.toString, and in fact Cast.toString would just make this code slower than it already is when returning due to the slight overhead.

casting the inputs on the other hand is a different thing entirely and should be done whenever the input accepts dynamic or possible differing of type user inputs, in this case Cast.toString SHOULD be used before passing the value to Complex, even if the try catch exists it is good practice.

thanks for the tip, @yuri-kiss! also @Brackets-Coder, the true reason we used .toString() is because no other function will output the strings we want

Brackets-Coder · 2025-05-09T02:34:32Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+  glideComplex (args, util) { //Do you recognize this? Answer at the end!
+	if (util.stackFrame.timer) {
+	  const timeElapsed = util.stackFrame.timer.timeElapsed();
+	  if (timeElapsed < util.stackFrame.duration * 1000) {
+		// We've moving! And we'll move again.
+		const frac = timeElapsed / (util.stackFrame.duration * 1000);
+		const dx = frac * (util.stackFrame.endX - util.stackFrame.startX);
+		const dy = frac * (util.stackFrame.endY - util.stackFrame.startY);
+		util.target.setXY(util.stackFrame.startX + dx, util.stackFrame.startY + dy);
+		util.yield();
+	  } else {
+		// We're done! Now, lets end this
+		util.target.setXY(util.stackFrame.endX, util.stackFrame.endY);
+	  }
+	} else {
+	  // We're starting! So, new Timer!
+	  util.stackFrame.timer = new Timer();
+	  util.stackFrame.timer.start();
+	  util.stackFrame.duration = args.SECS;
+	  util.stackFrame.startX = util.target.x;
+	  util.stackFrame.startY = util.target.y;
+	  util.stackFrame.endX = Complex(args.COMPLEX).re; //A little edit
+	  util.stackFrame.endY = Complex(args.COMPLEX).im;
+	  if (util.stackFrame.duration <= 0) {
+		// We can't glide -1 seconds, can we?
+		util.target.setXY(util.stackFrame.endX, util.stackFrame.endY);
+		return;
+	  }
+	util.yield();
+	}
+  }


This seems really unoptimized

yea i just copied the code from Scratch-vm because we didn't know how to glide it ourselves

even asked ChatGPT, we couldn't find any optimization

Brackets-Coder · 2025-05-09T02:34:54Z

extensions/Kenay-With-a-Y-At-The-End/Complexify!.js

+  convertComplex({ ANGLE, TOSMTH }) {
+	try {
+	  if (ANGLE == "") {
+		return 0;
+	  }
+	  const cInstance = Complex(ANGLE);
+	  switch (TOSMTH) {
+		case 'degs to rads': if (cInstance.im == 0) return (cInstance.re * 0.017453292519943295) % twoPi; 
+													return cInstance.mul(0.017453292519943295).toString(); break;
+		case '𝜋': return cInstance.mul(3.141592653589793).toString(); break;
+		case 'rads to degs': if (cInstance.im == 0) return (cInstance.re * 57.29577951308232) % 360; 
+													return cInstance.mul(57.29577951308232).toString(); break;
+		default: return NaN
+	  }
+	} catch (e) {
+	  console.log(e);
+	  return 0;
+	}
+  }


Oh my gosh the formatting is crazy I'll see if I can fix it

that's not suppoded to happen

Just learn I can !format

Brackets-Coder · 2025-05-09T02:35:59Z

!format

yuri-kiss · 2025-05-09T03:21:42Z

This is riddled with licensing issues, poor code formatting, horrible practices and lots of spelling mistakes, I am making this a draft until further notice...

I'll add a better glideComplex, more Scratch.Cast and the minified code later. For now, small changes first

Still working on some thing though. I'll tell you when it's ready.

Kenay555 · 2025-05-10T01:42:25Z

Generally speaking you should try to follow formatting best practices so your code doesn't look cluttered. Additionally, try to avoid opening new pull requests when it isn't necessary and you could just update the original :)

@Brackets-Coder, I'm new to JS and GitHub and that sort of stuff. I don't know a lot of things. Some things, but not all of them. I didn't knew that you could edit pull-requesting files until recently, after I created this new pull request.
But don't take me like an ignorant either. I may be learning English and JS, but I learned enough to understand what you're saying. I'll always try my best to reach my goal, even if it takes me a new set of rules to learn.
So don't expect me to be a perfect coder, nor be a random guy that has a laptop and asks ChatGPT and other coders to do all work for him. Just wanting to point that out.
Also, @yuri-kiss, what's wrong about the licence? ClickerTale_2 used MPL-2.0, as reccomended by the CONTRIBUTING.md,

This is riddled with licensing issues, poor code formatting, horrible practices and lots of spelling mistakes, I am making this a draft until further notice...

And which are the horrible practices? Now that I know how to edit files, maybe I can correct Complexify!.js

CubesterYT · 2025-05-10T03:59:30Z

!format

Brackets-Coder · 2025-05-10T11:54:18Z

Generally speaking you should try to follow formatting best practices so your code doesn't look cluttered. Additionally, try to avoid opening new pull requests when it isn't necessary and you could just update the original :)

@Brackets-Coder, I'm new to JS and GitHub and that sort of stuff. I don't know a lot of things. Some things, but not all of them. I didn't knew that you could edit pull-requesting files until recently, after I created this new pull request. But don't take me like an ignorant either. I may be learning English and JS, but I learned enough to understand what you're saying. I'll always try my best to reach my goal, even if it takes me a new set of rules to learn. So don't expect me to be a perfect coder, nor be a random guy that has a laptop and asks ChatGPT and other coders to do all work for him. Just wanting to point that out. Also, @yuri-kiss, what's wrong about the licence? ClickerTale_2 used MPL-2.0, as reccomended by the CONTRIBUTING.md,

This is riddled with licensing issues, poor code formatting, horrible practices and lots of spelling mistakes, I am making this a draft until further notice...

And which are the horrible practices? Now that I know how to edit files, maybe I can correct Complexify!.js

Absolutely not trying to be critical, we all were there once and it was only recently (in the past few months) that I really started with Github. It's an understandable situation, I'm just here to try to help you through it.

Kenay555 · 2025-05-21T21:56:41Z

!format (heard these fix smth idk)

github-actions · 2025-05-21T21:57:18Z

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

Yep. MORE THINGIES. Thanks to every error you've found, it's better than ever. Can't wait to see it at the gallery!

Kenay555 · 2025-05-21T22:10:56Z

!format (for the update. two done, one to go)

Basic changes :)

Checked again. what is define? idk

github-actions · 2025-05-21T23:06:25Z

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

Testing some small changes

Let's C if it works

Kenay555 · 2025-05-21T23:42:18Z

!format

github-actions · 2025-05-21T23:42:58Z

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

Kenay555 · 2025-05-22T00:16:58Z

After ~~half an hour~~ hours of coding, I got it. No more untranslated strings, no more wierd formatting, no more distracting comments, and no more horrible practices. Only Complexify!, no more.

Thanks @Brackets-Coder for telling me where I could be better.
Thanks @yuri-kiss for telling me some tips and in what I was wrong.
Thanks @CubesterYT and @CubesterYT for just passing by.
And thanks @Clickertale2 for being always there, always helping.

Fixing such a wierd extension is truly hard, but enhancing #2091 was really worth it.
All three checks are done, all three green successful checks.
I'm not sure what's next, do I just keep waiting? Do I start making the image? Or did it ended before its start?

What now?

(also i thought !format just meant my formatting wasn't good, my bad)

github-actions · 2025-05-22T00:17:41Z

The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files.

Brackets-Coder · 2025-05-22T00:32:46Z

For now, we'll go through the next round of reviews before merging just to make sure everything is perfect and add some policing details before it gets merged. It's going to be really nitpicky and specific and detailed so just warning you ahead of time if some requests seem odd.

Additionally, we strongly recommend a gallery thumbnail, so if you haven't started making that you should do that now or generate one with a tool of your choice (assuming proper attribution and credit of sources). If you like, you can also write documentation and add sample projects, but these aren't required.

CubesterYT · 2025-05-22T00:48:14Z

Also make sure the extension still works the same after all those changes

Kenay555 · 2025-05-22T01:12:59Z

@CubesterYT: Also make sure the extension still works the same after all those changes

It does! Maybe I'll edit it in the future due to silly factorial issues (of course, I set hideFromPalette: true to every factorial-related), but outside of that it's safe to use. I tested it, and if it doesn't- please tell me!

[I FORGOT THE LICENCE THINGIE]

Kenay555 · 2025-05-23T22:07:50Z

A teeny-tiny change just for it to be better [bet you won't notice] but it's not like the !format is wrong

Enhanced extension: Complexify!.js

e5fee6f

A better extension for complex numbers, fixing all the issues with the original Complexity!

github-actions bot added the pr: new extension Pull requests that add a new extension label May 9, 2025

Brackets-Coder reviewed May 9, 2025

View reviewed changes

yuri-kiss marked this pull request as draft May 9, 2025 03:21

Kenay555 added 2 commits May 9, 2025 13:31

Erasing some comments on Complexify!.js

bc341f3

I'll add a better glideComplex, more Scratch.Cast and the minified code later. For now, small changes first

Updated Complexify!.js again

5b134e3

Still working on some thing though. I'll tell you when it's ready.

[Automated] Format code

aa7afc9

Kenay555 marked this pull request as ready for review May 10, 2025 17:54

Updated Complexify!.js again again

a5a5417

Yep. MORE THINGIES. Thanks to every error you've found, it's better than ever. Can't wait to see it at the gallery!

DangoCat and others added 5 commits May 21, 2025 22:11

[Automated] Format code

09c7e18

Lint.ing Complexify!.js - Part 1

e5e58d4

Basic changes :)

[Automated] Format code

443a673

Lint.ing Complexify!.js - Part 2

b995536

Checked again. what is define? idk

[Automated] Format code

e0000b9

Kenay555 added 2 commits May 21, 2025 18:14

Lint.ing Complexify!.js - Part 3 - The test

33d0b63

Testing some small changes

Lint.ing Complexify!.js - Part 3 - The C

e1f46d2

Let's C if it works

[Automated] Format code

cc23937

Lint.ing Complexify!.js - Part 5 - I forgot to write 4 on the other one

43bbaa6

Kenay555 and others added 2 commits May 21, 2025 18:52

Lint-ing Complexify!.js - Part 6 - I HATE LINT-ING

6a0b511

[Automated] Format code

ff4c456

A teeny-tiny change

a3ad702

[I FORGOT THE LICENCE THINGIE]

[Automated] Format code

1674a23

Uh oh!

Enhanced extension: Complexify!.js #2113

Are you sure you want to change the base?

Enhanced extension: Complexify!.js #2113

Uh oh!

Conversation

Kenay555 commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kenay555 commented May 9, 2025

Uh oh!

Brackets-Coder left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder commented May 9, 2025

Uh oh!

yuri-kiss commented May 9, 2025

Uh oh!

Kenay555 commented May 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CubesterYT commented May 10, 2025

Uh oh!

Brackets-Coder commented May 10, 2025

Uh oh!

Kenay555 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kenay555 commented May 9, 2025 •

edited

Loading

Brackets-Coder May 9, 2025 •

edited

Loading

Brackets-Coder May 9, 2025 •

edited

Loading

Kenay555 commented May 10, 2025 •

edited

Loading

Kenay555 commented May 21, 2025 •

edited

Loading

Kenay555 commented May 21, 2025 •

edited

Loading

Kenay555 commented May 22, 2025 •

edited

Loading