-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Include severity changelog template for MD #660
base: main
Are you sure you want to change the base?
Conversation
Add: Change error level on GroupChanges
Add consideration for the changelog as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 87.52% 87.52%
=======================================
Files 237 237
Lines 13726 13728 +2
=======================================
+ Hits 12014 12016 +2
Misses 1298 1298
Partials 414 414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @DevMrRober, BEFORE:API Changelog 1.0.0 vs. 1.0.1GET /api/{domain}/{project}/badges/security-score
GET /api/{domain}/{project}/install-command
POST /register
AFTER:API Changelog 1.0.0 vs. 1.0.1GET /api/{domain}/{project}/badges/security-score
GET /api/{domain}/{project}/install-command
POST /register
|
Hello @reuvenharrison Yes, that's correct. My goal here is to highlight the severity of the breaking change, making it more descriptive and informative for users. This approach ensures that when a breaking change is introduced, users can immediately understand its impact. Additionally, this mechanism supports custom severity levels for greater flexibility |
Okay, I understand that you added the "error:" and "warning:" titles.
If the sole purpose of your PR it to differentiate between error and warning then perhaps we can use: See: https://github.com/ikatyang/emoji-cheat-sheet?tab=readme-ov-file#warning |
How do you see this output?, for me it brings out the severity apart from the icon. If you like it I add the changes to the PR API Changelog 5.0.5 vs. 5.0.20GET /users
POST /users
PATCH /users/{userId}
PUT /users/{userId}
|
Summary
This PR introduces a severity classification to the API changelog markdown.
Changes made
GroupChanges
function informatters/changes_by_endpoint.go
changelog.md
template informatters/templates/changelog.md
.Reason for change
Tests
Reviewers