Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2569): leave community settings #2648

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kingalg
Copy link
Collaborator

@kingalg kingalg commented Oct 31, 2024

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@mike-kiss, those are the changes requested in the #2569 issue. I heard that you volunteered to check it! Thank you, and let me know if you have any questions or requests.

  • Instead of modal, leaving a community is now a part of the sidebar.
  • The "go back" button takes the user to the Settings.
  • The "Leave Community" button inside the Leave Community section of Settings initiates the leaving community process and takes the user to the "Join Community" screen.

@kingalg kingalg requested a review from mike-kiss October 31, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant