fix: channel and community naming #2302 #2584
Conversation
There was a problem hiding this comment.
I have stylistic qualms with this change. Mostly related to allowing whitespaces which I think make for a bad experience telling apart channels, typing references to them, and displaying them in the UI. I think fully pulling out pattern matching for channels and communities is the wrong move. I found this article for supporting international characters which might be worth testing, but I also don't know if this is something we want to support outside of the community name for the sake of users easily referencing channels. I think that in certain resolutions it may be hard to tell certain diacritical marks apart which would make it difficult to search or reference them. @holmesworcester could overrule me there though
| @@ -90,7 +90,7 @@ describe('Add new channel', () => { | |||
| const alice = await factory.create<ReturnType<typeof identity.actions.addNewIdentity>['payload']>('Identity', { | |||
| nickname: 'alice', | |||
| }) | |||
| const channelName = { input: 'my-Super Channel ', output: 'my-super-channel-' } | |||
| const channelName = { input: 'my-Super Channel ', output: 'my-Super Channel ' } | |||
There was a problem hiding this comment.
I don't think that allowing spaces in channel names makes sense for a couple reasons. It's impossible to tell how many spaces are in a channel name when referencing it. It looks like a bug in the UI when a channel name starts with white spaces. Also, the industry standard is to not allow capitals or spaces in channel names.
| @@ -15,10 +15,6 @@ export const communityNameField = (name = 'name'): FieldData => { | |||
| value: 20, | |||
| message: CommunityNameErrors.NameTooLong, | |||
| }, | |||
| pattern: { | |||
There was a problem hiding this comment.
I think it's worth still disallowing leading and trailing whitespace for the sake of aesthetics. There are also options for regexing to include diacritical marks if we want to continue to disallow special characters, but support international alphabets.
Pull Request Checklist
(Optional) Mobile checklist
Please ensure you completed the following checks if you did any changes to the mobile package: