Added stale-if-error and fixed bug for frontend cache staleWhileRevaidate config (#21886) #21887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
staleWhileRevaidate
config not being passed into thecacheControl()
middleware if it is set via the frontend caching config. It also adds thestaleIfError
configuration to allow thestale-if-error
Cache-Control
header directive.Tests have also been added for varying cases of the directives including when the Ghost config is not set.
Documentation from https://ghost.org/docs/config/#caching will also need to be updated. Happy to update this given the source.
yarn test
andyarn lint
)Closes issue #21886