Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portal.json #21829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update portal.json #21829

wants to merge 3 commits into from

Conversation

alexrodba
Copy link
Contributor

@alexrodba alexrodba commented Dec 8, 2024

Corrected typos and style. Added missing translations. Added coherent style (tu vs vostè) across files.

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Corrected typos and style. Added missing translations. Added coherent style (tu vs vostè) across files.
"In the event a permanent failure is received when attempting to send a newsletter, emails will be disabled on the account.": "En cas que es rebi un error permanent en intentar enviar un butlletí, els correus electrònics es desactivaran en aquest compte.",
"In your email client add {{senderEmail}} to your contacts list. This signals to your mail provider that emails sent from this address should be trusted.": "Afegeix {{senderEmail}} a la llista de contactes del teu client de correu electrònic. Això indica al teu proveïdor de correu que els correus electrònics enviats des d'aquesta adreça haurien de ser de confiança.",
"Invalid email address": "Adreça de correu electrònic invàlida",
"Jamie Larson": "Jamie Larson",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jamie Larson is intended to be a placeholder name. Feel free to suggest a name that would be recognizable to Catalan speakers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, will do it.

@cathysarisky
Copy link
Contributor

Hi @Zagur ! Do you have a moment to review these Catalan refinements?

Added more cohesiveness between imperative vs infinitive in buttons + other small style and typos fixes.
Copy link
Contributor Author

@alexrodba alexrodba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added further changes

@cathysarisky
Copy link
Contributor

Hi @alexrodba ! Hi @Hana-Gausfain ! Could you two please discuss/look over each others' PRs, as the current Catalan contributors? :)

@Zagur
Copy link
Contributor

Zagur commented Dec 14, 2024

Hi @Zagur ! Do you have a moment to review these Catalan refinements?

I'm currently on vacation. I can review it next week without any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants