Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added migration to include donation_message in donation_payment_events #20839

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

ronaldlangeveld
Copy link
Member

ref PLG-197

  • DB migration to add donation_message to donation_payment_events table

ref PLG-197

- DB migration to add `donation_message` to `donation_payment_events`
  table
Copy link
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@github-actions github-actions bot added the migration [pull request] Includes migration for review label Aug 28, 2024
@ronaldlangeveld ronaldlangeveld changed the title Migration to add donation_message to table Added migration to add donation_message to donation_payment_events table Aug 28, 2024
@ronaldlangeveld ronaldlangeveld changed the title Added migration to add donation_message to donation_payment_events table Added migration to include donation_message in donation_payment_events Aug 28, 2024
@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review August 28, 2024 05:58
@ronaldlangeveld ronaldlangeveld merged commit 41e696f into main Aug 28, 2024
22 checks passed
@ronaldlangeveld ronaldlangeveld deleted the donations-field-migration branch August 28, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration [pull request] Includes migration for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants