Backfilled missing offer redemptions #20647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
migration
|
It looks like this PR contains a migration 👀 General requirements
Schema changesN/A Data changes
|
cmraible
force-pushed
the
chris-eng-1440-backfill-offer-redemption-data-with-a-migration
branch
2 times, most recently
from
f4981c3
to
d0dd82e
Compare
cmraible
changed the title
cmraible
commented
Jul 31, 2024
.../core/server/data/migrations/versions/5.89/2024-07-30-19-51-06-backfill-offer-redemptions.js
Outdated
Show resolved
Hide resolved
ErisDS
reviewed
Jul 31, 2024
.../core/server/data/migrations/versions/5.89/2024-07-30-19-51-06-backfill-offer-redemptions.js
Outdated
Show resolved
Hide resolved
| if (rows && rows.length > 0) { | ||
| logging.info(`Backfilling ${rows.length} offer redemptions`); | ||
| // Generate IDs for each row | ||
| const offerRedemptions = rows.map((row) => { |
There was a problem hiding this comment.
@daniellockyer as someone who has seen a lot of these go by, do you have any concerns with this loop?
There was a problem hiding this comment.
Just for my own due diligence, I did a search and found this is a pretty common pattern in migrations, specifically for generating object IDs. I checked a couple of them, and did a search in Slack for their rollout and haven't found any drama.
Also tested on staging with 40k+ redemptions to backfill (max in production will be ~4k) and it completed in <3 seconds
9larsons
reviewed
Jul 31, 2024
.../core/server/data/migrations/versions/5.89/2024-07-30-19-51-06-backfill-offer-redemptions.js
Outdated
Show resolved
Hide resolved
9larsons
reviewed
Jul 31, 2024
.../core/server/data/migrations/versions/5.89/2024-07-30-19-51-06-backfill-offer-redemptions.js
Show resolved
Hide resolved
cmraible
force-pushed
the
chris-eng-1440-backfill-offer-redemption-data-with-a-migration
branch
3 times, most recently
from
ed6774c
to
e953489
Compare
ref https://linear.app/tryghost/issue/ENG-1440/backfill-offer-redemption-data-with-a-migration ref TryGhost@bf895e6 There was a bug that caused offer redemptions to not be recorded in the database for some subscriptions that were created with an offer. The bug was fixed in the references commit above. This commit backfills the missing redemptions, based on the subscriptions that have an `offer_id` but no corresponding offer redemptions.
cmraible
force-pushed
the
chris-eng-1440-backfill-offer-redemption-data-with-a-migration
branch
from
e953489
to
d946577
Compare
cmraible
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://linear.app/tryghost/issue/ENG-1440/backfill-offer-redemption-data-with-a-migration
There was a bug that caused offer redemptions to not be recorded in the database for some subscriptions that were created with an offer. However, we still have the
offer_idattached to the subscriptions, so we are able to backfill the missing redemptions. The bug was fixed in bf895e6This commit only contains a migration, which queries for subscriptions that have an
offer_idbut do not have any offer redemptions recorded, and adds any missing redemptions to theoffer_redemptionstable.